Skip to content

Add close / shutdown method to samplers #8535

Description

@jack-berg

Sampler doesn't have a shutdown / close method.

This is a problem for samplers like JaegerRemoteSampler, which manage resources like thread pools / connections which need to be shutdown to prevent memory leaks.

Noticed this while debugging noisy build output.

We should fix by adding shutdown / close methods to the base Sampler interface, and calling when SdkTracerProvider is shutdown / closed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature RequestSuggest an idea for this project

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions