Detect evicted current chunk and invalidate memoized chunk on metadata reload

Author: arukompas

src/Concerns/LogIndex/CanSplitIndexIntoChunks.php

@@ -35,7 +35,13 @@ public function getCurrentChunk(): LogIndexChunk
             $this->currentChunk = LogIndexChunk::fromDefinitionArray($this->currentChunkDefinition);
 
             if ($this->currentChunk->size > 0) {
-                $this->currentChunk->data = $this->getChunkDataFromCache($this->currentChunk->index, []);
+                $data = $this->getChunkDataFromCache($this->currentChunk->index);
+                $this->currentChunk->data = $data ?? [];
+
+                if (is_null($data)) {
+                    // The current chunk was evicted from cache while the metadata survived.
+                    $this->markForRebuild();
+                }
             }
         }
 

src/Concerns/LogIndex/HasMetadata.php

@@ -36,5 +36,9 @@ protected function loadMetadata(): void
         $this->maxChunkSize = $data['max_chunk_size'] ?? self::DEFAULT_CHUNK_SIZE;
         $this->chunkDefinitions = $data['chunk_definitions'] ?? [];
         $this->currentChunkDefinition = $data['current_chunk_definition'] ?? [];
+
+        // The memoized chunk object is derived from the definition loaded above,
+        // so it must not survive a metadata (re)load — e.g. after clearCache().
+        unset($this->currentChunk);
     }
 }

src/Concerns/LogIndex/PreservesIndexingProgress.php

@@ -42,6 +42,10 @@ public function incomplete(): bool
 
     public function markForRebuild(): void
     {
+        if ($this->rebuildRequired ?? false) {
+            return;
+        }
+
         $this->rebuildRequired = true;
 
         // Persist immediately so the next request sees the flag even though

tests/Unit/LogReaderTest.php

@@ -116,6 +116,37 @@
         ->and(count($logReader->reset()->get()))->toBe(2);
 });
 
+it('rebuilds the index when the current chunk is evicted but metadata survives', function () {
+    File::append($this->file->path, PHP_EOL.makeLaravelLogEntry());
+
+    $path = $this->file->path;
+    // Default chunk size, so both entries live in the single (current) chunk.
+    $this->file->logs()->scan();
+
+    expect($this->file->logs()->total())->toBe(2);
+
+    LogViewerCache::forget(GenerateCacheKey::for($this->file->index(), 'chunk:0'));
+
+    // The request that discovers the eviction flags the index for a rebuild.
+    IndexedLogReader::clearInstances();
+    $logReader = (new LogFile($path))->logs();
+
+    expect(count($logReader->get()))->toBe(0)
+        ->and($logReader->requiresScan())->toBeTrue();
+
+    // The next request (e.g. a page reload) rebuilds the index from scratch.
+    IndexedLogReader::clearInstances();
+    $logReader = (new LogFile($path))->logs();
+
+    expect($logReader->requiresScan())->toBeTrue();
+
+    $logReader->scan();
+
+    expect($logReader->requiresScan())->toBeFalse()
+        ->and($logReader->total())->toBe(2)
+        ->and(count($logReader->reset()->get()))->toBe(2);
+});
+
 it('does not flag a rebuild when reading a chunk the index does not know about', function () {
     $this->file->logs()->scan();