Skip to content

Commit 2fef534

Browse files
Oliver Amescodex
andcommitted
Fix Sentry failed-request capture noise
Disable Sentry's failed HTTP request capture in the crash-only reporter configuration. This keeps transient Sparkle/GitHub update download failures, such as release-asset 502 responses, out of Ping Warden crash reporting while preserving crash capture. Bump Ping Warden to 2.4.1 and add patch release notes. Co-Authored-By: Codex <codex@openai.com>
1 parent 65fb84f commit 2fef534

6 files changed

Lines changed: 24 additions & 12 deletions

File tree

PingWarden/PingWarden.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@
413413
"@executable_path/../Frameworks",
414414
);
415415
MACOSX_DEPLOYMENT_TARGET = 13.0;
416-
MARKETING_VERSION = 2.4.0;
416+
MARKETING_VERSION = 2.4.1;
417417
PRODUCT_BUNDLE_IDENTIFIER = com.amesvt.pingwarden;
418418
PRODUCT_NAME = "Ping Warden";
419419
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -454,7 +454,7 @@
454454
"@executable_path/../Frameworks",
455455
);
456456
MACOSX_DEPLOYMENT_TARGET = 13.0;
457-
MARKETING_VERSION = 2.4.0;
457+
MARKETING_VERSION = 2.4.1;
458458
PRODUCT_BUNDLE_IDENTIFIER = com.amesvt.pingwarden;
459459
PRODUCT_NAME = "Ping Warden";
460460
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -650,7 +650,7 @@
650650
"@executable_path/../../../../Frameworks",
651651
);
652652
MACOSX_DEPLOYMENT_TARGET = 26.0;
653-
MARKETING_VERSION = 2.4.0;
653+
MARKETING_VERSION = 2.4.1;
654654
PRODUCT_BUNDLE_IDENTIFIER = com.amesvt.pingwarden.widget;
655655
PRODUCT_NAME = "$(TARGET_NAME)";
656656
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -687,7 +687,7 @@
687687
"@executable_path/../../../../Frameworks",
688688
);
689689
MACOSX_DEPLOYMENT_TARGET = 26.0;
690-
MARKETING_VERSION = 2.4.0;
690+
MARKETING_VERSION = 2.4.1;
691691
PRODUCT_BUNDLE_IDENTIFIER = com.amesvt.pingwarden.widget;
692692
PRODUCT_NAME = "$(TARGET_NAME)";
693693
PROVISIONING_PROFILE_SPECIFIER = "";

PingWarden/PingWarden/CrashReporter.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
// Settings → Advanced → Privacy. The choice persists; only fresh
1212
// installs and existing users launching v2.3.1 see the default.
1313
// • No IP address (sendDefaultPii = false).
14-
// • No network breadcrumbs — would otherwise leak TCP-probe target
15-
// hostnames (e.g. user's DNS server) into crash payloads.
14+
// • No network breadcrumbs, spans, or failed-request events — those
15+
// would otherwise leak updater and TCP-probe URLs into crash payloads.
1616
// • No performance tracing or profiling — crashes only.
1717
// • No app-lifecycle session tracking (enableAutoSessionTracking = false).
1818
// • beforeSend re-checks the preference as defense-in-depth, so a
@@ -76,6 +76,7 @@ enum CrashReporter {
7676

7777
options.enableNetworkTracking = false
7878
options.enableNetworkBreadcrumbs = false
79+
options.enableCaptureFailedRequests = false
7980
options.enableAppHangTracking = false
8081
options.enableFileIOTracing = false
8182

PingWarden/PingWarden/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
<key>CFBundlePackageType</key>
1616
<string>APPL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>2.4.0</string>
18+
<string>2.4.1</string>
1919
<key>CFBundleVersion</key>
20-
<string>2.4.0</string>
20+
<string>2.4.1</string>
2121
<key>GCSupportsControllerUserInteraction</key>
2222
<false/>
2323
<key>LSMinimumSystemVersion</key>

PingWarden/PingWardenHelper/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
<key>CFBundlePackageType</key>
1616
<string>BNDL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>2.4.0</string>
18+
<string>2.4.1</string>
1919
<key>CFBundleVersion</key>
20-
<string>2.4.0</string>
20+
<string>2.4.1</string>
2121
<key>LSMinimumSystemVersion</key>
2222
<string>13.0</string>
2323
<key>NSHumanReadableCopyright</key>

PingWarden/PingWardenWidget/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
<key>CFBundlePackageType</key>
1616
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>2.4.0</string>
18+
<string>2.4.1</string>
1919
<key>CFBundleVersion</key>
20-
<string>2.4.0</string>
20+
<string>2.4.1</string>
2121
<key>NSExtension</key>
2222
<dict>
2323
<key>NSExtensionPointIdentifier</key>

RELEASE_NOTES.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
# Ping Warden 2.4.1
2+
3+
[Support Ping Warden on Buy Me a Coffee](https://buymeacoffee.com/oliverames)
4+
5+
Patch release for the 2.4 line.
6+
7+
## Reliability
8+
- **Crash-reporting privacy/noise fix**: Sentry now explicitly disables failed HTTP request capture, so transient GitHub/Sparkle download errors like a 502 from a release asset do not get reported as Ping Warden errors. Crash reporting remains crash-only.
9+
10+
---
11+
112
# Ping Warden 2.4.0
213

314
[Support Ping Warden on Buy Me a Coffee](https://buymeacoffee.com/oliverames)

0 commit comments

Comments
 (0)