From ae1a91ccd62d23e8d123bc2b591a83b912d24afd Mon Sep 17 00:00:00 2001 From: coreybutler <770982+coreybutler@users.noreply.github.com> Date: Thu, 5 Nov 2026 20:58:40 -0600 Subject: [PATCH] fix: skip symlink detect files in AutoUse Refuse planted .nvmrc/.node-version symlinks when resolving the active version so AutoUse cannot follow attacker-controlled detect files (nvm-sh GHSA-j6ch-mq5c-3h4x class). --- resolver/detect_reparse_other.go | 9 +++++++ resolver/detect_reparse_test.go | 39 ++++++++++++++++++++++++++++++ resolver/detect_reparse_windows.go | 16 ++++++++++++ resolver/resolver.go | 4 +++ 4 files changed, 68 insertions(+) create mode 100644 resolver/detect_reparse_other.go create mode 100644 resolver/detect_reparse_test.go create mode 100644 resolver/detect_reparse_windows.go diff --git a/resolver/detect_reparse_other.go b/resolver/detect_reparse_other.go new file mode 100644 index 0000000..c46e965 --- /dev/null +++ b/resolver/detect_reparse_other.go @@ -0,0 +1,9 @@ +//go:build !windows + +package resolver + +// detectFileIsReparse is a no-op off Windows. +func detectFileIsReparse(path string) bool { + _ = path + return false +} diff --git a/resolver/detect_reparse_test.go b/resolver/detect_reparse_test.go new file mode 100644 index 0000000..e2dd28d --- /dev/null +++ b/resolver/detect_reparse_test.go @@ -0,0 +1,39 @@ +package resolver + +import ( + "os" + "path/filepath" + "testing" +) + +func TestDetectFileIsReparseRegular(t *testing.T) { + path := filepath.Join(t.TempDir(), ".nvmrc") + if err := os.WriteFile(path, []byte("20.11.0\n"), 0o644); err != nil { + t.Fatalf("WriteFile: %v", err) + } + if detectFileIsReparse(path) { + t.Fatal("regular file reported as reparse") + } +} + +func TestDetectFileIsReparseSymlink(t *testing.T) { + dir := t.TempDir() + target := filepath.Join(dir, "secret.txt") + link := filepath.Join(dir, ".nvmrc") + if err := os.WriteFile(target, []byte("token=leak\n"), 0o644); err != nil { + t.Fatalf("WriteFile: %v", err) + } + if err := os.Symlink(target, link); err != nil { + t.Skipf("symlink not permitted: %v", err) + } + if !detectFileIsReparse(link) { + t.Fatal("symlink detect file not reported as reparse") + } +} + +func TestDetectFileIsReparseMissing(t *testing.T) { + path := filepath.Join(t.TempDir(), "missing.nvmrc") + if detectFileIsReparse(path) { + t.Fatal("missing path reported as reparse") + } +} diff --git a/resolver/detect_reparse_windows.go b/resolver/detect_reparse_windows.go new file mode 100644 index 0000000..cdff976 --- /dev/null +++ b/resolver/detect_reparse_windows.go @@ -0,0 +1,16 @@ +//go:build windows + +package resolver + +import "os" + +// detectFileIsReparse reports symlink detect files so AutoUse does not follow +// planted links (nvm-sh GHSA-j6ch-mq5c-3h4x class). ModeSymlink covers the +// typical .nvmrc → secret file plant; junctions are uncommon for this vector. +func detectFileIsReparse(path string) bool { + info, err := os.Lstat(path) + if err != nil { + return false + } + return info.Mode()&os.ModeSymlink != 0 +} diff --git a/resolver/resolver.go b/resolver/resolver.go index fe6cc6e..49cfbbc 100644 --- a/resolver/resolver.go +++ b/resolver/resolver.go @@ -273,6 +273,10 @@ func ResolveActiveVersion(cwd ...string) (string, error) { for _, file := range cfg.AutoDetect { file = filepath.Join(wd, file) + if detectFileIsReparse(file) { + continue + } + if _, err := os.Stat(file); err == nil { if raw, err := os.ReadFile(file); err == nil { if strings.ToLower(filepath.Ext(file)) == ".json" {