From b2110b01abd0d955bfc7fe2139a114dfc76405e9 Mon Sep 17 00:00:00 2001 From: coreybutler <770982+coreybutler@users.noreply.github.com> Date: Fri, 30 Oct 2026 21:49:58 -0500 Subject: [PATCH] fix: require Governance for firewall allow/deny lists Version and approved-module allow/deny write Policies values that are inert without Governance. Fail closed with a clear error. Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com> --- src/commands/firewall/root.go | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/commands/firewall/root.go b/src/commands/firewall/root.go index 75f7004..4354d68 100644 --- a/src/commands/firewall/root.go +++ b/src/commands/firewall/root.go @@ -2,6 +2,7 @@ package firewall import ( "common/acl" + license "common/license" "common/modulefirewall" "common/preferences" "common/registry" @@ -125,6 +126,16 @@ func requireCertified() error { return nil } +func requireGovernancePolicy() error { + if err := requireCertified(); err != nil { + return err + } + if !license.AllowsMachinePolicy() { + return fmt.Errorf("module/version firewall allow|deny requires a Governance license (machine policy)") + } + return nil +} + func policyKey(name string) string { root := strings.TrimSpace(preferences.MACHINE_POLICY_ROOT) if root == "" { @@ -534,21 +545,21 @@ func removeTrusted(entries []string, machine bool) error { } func (a *AllowVersion) Run() error { - if err := requireCertified(); err != nil { + if err := requireGovernancePolicy(); err != nil { return err } return appendPolicyMulti("VersionAllowList", a.Entries, false) } func (d *DenyVersion) Run() error { - if err := requireCertified(); err != nil { + if err := requireGovernancePolicy(); err != nil { return err } return appendPolicyMulti("VersionAllowList", d.Entries, true) } func (a *AllowModule) Run() error { - if err := requireCertified(); err != nil { + if err := requireGovernancePolicy(); err != nil { return err } key, label := "approved_modules", "ApprovedModules" @@ -559,7 +570,7 @@ func (a *AllowModule) Run() error { } func (d *DenyModule) Run() error { - if err := requireCertified(); err != nil { + if err := requireGovernancePolicy(); err != nil { return err } key, label := "approved_modules", "ApprovedModules"