fix(task-streaming): fix psalm issues, run cs:fix, gen openapi specs

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

core/Controller/TaskProcessingApiController.php

@@ -647,7 +647,7 @@ public function setResult(int $taskId, ?array $output = null, ?string $errorMess
 	 * Sets the task intermediate result while it is running
 	 *
 	 * @param int $taskId The id of the task
-	 * @param array<string,mixed>|null $output The intermediate task output, files are represented by their IDs
+	 * @param array<string,mixed> $output The intermediate task output, files are represented by their IDs
 	 * @return DataResponse<Http::STATUS_OK, array{task: CoreTaskProcessingTask}, array{}>|DataResponse<Http::STATUS_INTERNAL_SERVER_ERROR|Http::STATUS_NOT_FOUND, array{message: string}, array{}>
 	 *
 	 * 200: Result updated successfully

core/Migrations/Version35000Date20260527162338.php

@@ -6,6 +6,7 @@
  * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
+
 namespace OC\Core\Migrations;
 
 use Closure;

core/openapi-ex_app.json

@@ -2228,15 +2228,17 @@
                     }
                 ],
                 "requestBody": {
-                    "required": false,
+                    "required": true,
                     "content": {
                         "application/json": {
                             "schema": {
                                 "type": "object",
+                                "required": [
+                                    "output"
+                                ],
                                 "properties": {
                                     "output": {
                                         "type": "object",
-                                        "nullable": true,
                                         "description": "The intermediate task output, files are represented by their IDs",
                                         "additionalProperties": {
                                             "type": "object"

core/openapi-full.json

@@ -12038,15 +12038,17 @@
                     }
                 ],
                 "requestBody": {
-                    "required": false,
+                    "required": true,
                     "content": {
                         "application/json": {
                             "schema": {
                                 "type": "object",
+                                "required": [
+                                    "output"
+                                ],
                                 "properties": {
                                     "output": {
                                         "type": "object",
-                                        "nullable": true,
                                         "description": "The intermediate task output, files are represented by their IDs",
                                         "additionalProperties": {
                                             "type": "object"

lib/private/TaskProcessing/Manager.php

@@ -1227,16 +1227,23 @@ public function setTaskProgress(int $id, float $progress): bool {
 		return true;
 	}
 
+	#[\Override]
 	public function setTaskIntermediateOutput(int $id, array $output): bool {
 		// TODO: Not sure if we should rather catch the exceptions of getTask here and fail silently
 		$task = $this->getTask($id);
 		if ($task->getStatus() !== Task::STATUS_RUNNING) {
 			return false;
 		}
 		$userId = $task->getUserId();
-		if ($userId !== null && $userId !== '' && $this->appManager->isEnabledForAnyone('notify_push')) {
+		if ($userId !== null
+			&& $userId !== ''
+			&& $this->appManager->isEnabledForAnyone('notify_push')
+			&& class_exists('\OCA\NotifyPush\Queue\IQueue')
+		) {
 			try {
+				/** @psalm-suppress UndefinedClass */
 				$queue = Server::get(\OCA\NotifyPush\Queue\IQueue::class);
+				/** @psalm-suppress UndefinedClass */
 				$queue->push('notify_custom', [
 					'user' => $userId,
 					'message' => 'task_' . $task->getId(),

lib/public/TaskProcessing/ISynchronousOptionsProvider.php

@@ -7,7 +7,6 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-
 namespace OCP\TaskProcessing;
 
 use OCP\Files\File;
@@ -31,6 +30,7 @@ interface ISynchronousOptionsProvider extends ISynchronousProvider {
 	 * @throws ProcessingException
 	 * @since 35.0.0
 	 */
+	#[\Override]
 	public function process(
 		?string $userId,
 		array $input,

lib/public/TaskProcessing/SynchronousProviderOptions.php

@@ -4,6 +4,7 @@
  * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
+
 namespace OCP\TaskProcessing;
 
 /**
@@ -12,6 +13,13 @@
 class SynchronousProviderOptions {
 	private \Closure $reportOutput;
 
+	/**
+	 * @param bool $includeWatermarks Whether to include the watermark in the media output files or not
+	 * @param bool $preferStreaming Whether to prefer streaming the output or not
+	 * @param null|callable $reportOutput Callback for the provider to report the intermediate output (streaming)
+	 * @return void
+	 * @since 35.0.0
+	 */
 	public function __construct(
 		private readonly bool $includeWatermarks = false,
 		private readonly bool $preferStreaming = true,
@@ -24,14 +32,29 @@ public function __construct(
 			};
 	}
 
+	/**
+	 * Get the includeWatermarks option value
+	 * @return bool Whether to include the watermark in the media output files or not
+	 * @since 35.0.0
+	 */
 	public function getIncludeWatermarks(): bool {
 		return $this->includeWatermarks;
 	}
 
+	/**
+	 * Get the preferStreaming option value
+	 * @return bool Whether to prefer streaming the output or not
+	 * @since 35.0.0
+	 */
 	public function getPreferStreaming(): bool {
 		return $this->preferStreaming;
 	}
 
+	/**
+	 * Get the reportOutput option value
+	 * @return callable Callback for the provider to report the intermediate output (streaming)
+	 * @since 35.0.0
+	 */
 	public function getReportOutput(): callable {
 		return $this->reportOutput;
 	}

lib/public/TaskProcessing/Task.php

@@ -312,7 +312,7 @@ final public function setPreferStreaming(bool $preferStreaming): void {
 	}
 
 	/**
-	 * @psalm-return array{id: int, lastUpdated: int, type: string, status: 'STATUS_CANCELLED'|'STATUS_FAILED'|'STATUS_SUCCESSFUL'|'STATUS_RUNNING'|'STATUS_SCHEDULED'|'STATUS_UNKNOWN', userId: ?string, appId: string, input: array<string, list<numeric|string>|numeric|string>, output: ?array<string, list<numeric|string>|numeric|string>, customId: ?string, completionExpectedAt: ?int, progress: ?float, scheduledAt: ?int, startedAt: ?int, endedAt: ?int, allowCleanup: bool, includeWatermark: bool, userFacingErrorMessage: ?string}
+	 * @psalm-return array{id: int, lastUpdated: int, type: string, status: 'STATUS_CANCELLED'|'STATUS_FAILED'|'STATUS_SUCCESSFUL'|'STATUS_RUNNING'|'STATUS_SCHEDULED'|'STATUS_UNKNOWN', userId: ?string, appId: string, input: array<string, list<numeric|string>|numeric|string>, output: ?array<string, list<numeric|string>|numeric|string>, customId: ?string, completionExpectedAt: ?int, progress: ?float, scheduledAt: ?int, startedAt: ?int, endedAt: ?int, allowCleanup: bool, includeWatermark: bool, userFacingErrorMessage: ?string, preferStreaming: bool}
 	 * @since 30.0.0
 	 */
 	#[\Override]

openapi.json

@@ -15746,15 +15746,17 @@
                     }
                 ],
                 "requestBody": {
-                    "required": false,
+                    "required": true,
                     "content": {
                         "application/json": {
                             "schema": {
                                 "type": "object",
+                                "required": [
+                                    "output"
+                                ],
                                 "properties": {
                                     "output": {
                                         "type": "object",
-                                        "nullable": true,
                                         "description": "The intermediate task output, files are represented by their IDs",
                                         "additionalProperties": {
                                             "type": "object"