Skip to content

Commit 0e7451c

Browse files
authored
Reinject doc feedback (#1653)
* Reinject doc feedback * doc: mention privileged field path
1 parent 663a7e3 commit 0e7451c

9 files changed

Lines changed: 44 additions & 49 deletions

File tree

api/flowcollector/v1beta2/flowcollector_types.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -378,25 +378,24 @@ type FlowCollectorEBPF struct {
378378

379379
// `advanced` allows setting some aspects of the internal configuration of the eBPF agent.
380380
// This section is aimed mostly for debugging and fine-grained performance optimizations,
381-
// such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk. You can also
381+
// such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk. You can also
382382
// override the default Linux capabilities from there.
383383
// +optional
384384
Advanced *AdvancedAgentConfig `json:"advanced,omitempty"`
385385

386386
// List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br>
387387
// - `PacketDrop`: Enable the packets drop flows logging feature. This feature requires mounting
388-
// the kernel debug filesystem, so the eBPF agent pods must run as privileged.
389-
// If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
388+
// the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.<br>
390389
// - `DNSTracking`: Enable the DNS tracking feature.<br>
391390
// - `FlowRTT`: Enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
392391
// - `NetworkEvents`: Enable the network events monitoring feature, such as correlating flows and network policies.
393-
// This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
392+
// This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
394393
// It requires using the OVN-Kubernetes network plugin with the Observability feature.
395394
// IMPORTANT: This feature is available as a Technology Preview.<br>
396395
// - `PacketTranslation`: Enable enriching flows with packet translation information, such as Service NAT.<br>
397396
// - `EbpfManager`: [Unsupported (*)]. Use eBPF Manager to manage NetObserv eBPF programs. Pre-requisite: the eBPF Manager operator (or upstream bpfman operator) must be installed.<br>
398397
// - `UDNMapping`: Enable interfaces mapping to User Defined Networks (UDN). <br>
399-
// This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
398+
// This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
400399
// It requires using the OVN-Kubernetes network plugin with the Observability feature. <br>
401400
// - `IPSec`, to track flows between nodes with IPsec encryption. <br>
402401
// +optional
@@ -694,7 +693,7 @@ type FlowCollectorFLP struct {
694693

695694
// `advanced` allows setting some aspects of the internal configuration of the flow processor.
696695
// This section is aimed mostly for debugging and fine-grained performance optimizations,
697-
// such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
696+
// such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
698697
// +optional
699698
Advanced *AdvancedProcessorConfig `json:"advanced,omitempty"`
700699
}
@@ -1064,7 +1063,7 @@ type FlowCollectorConsolePlugin struct {
10641063

10651064
// `advanced` allows setting some aspects of the internal configuration of the console plugin.
10661065
// This section is aimed mostly for debugging and fine-grained performance optimizations,
1067-
// such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
1066+
// such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
10681067
// +optional
10691068
Advanced *AdvancedPluginConfig `json:"advanced,omitempty"`
10701069
}

bundle/manifests/flows.netobserv.io_flowcollectors.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2901,7 +2901,7 @@ spec:
29012901
description: |-
29022902
`advanced` allows setting some aspects of the internal configuration of the eBPF agent.
29032903
This section is aimed mostly for debugging and fine-grained performance optimizations,
2904-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk. You can also
2904+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk. You can also
29052905
override the default Linux capabilities from there.
29062906
properties:
29072907
capOverride:
@@ -3958,18 +3958,17 @@ spec:
39583958
description: |-
39593959
List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br>
39603960
- `PacketDrop`: Enable the packets drop flows logging feature. This feature requires mounting
3961-
the kernel debug filesystem, so the eBPF agent pods must run as privileged.
3962-
If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
3961+
the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.<br>
39633962
- `DNSTracking`: Enable the DNS tracking feature.<br>
39643963
- `FlowRTT`: Enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
39653964
- `NetworkEvents`: Enable the network events monitoring feature, such as correlating flows and network policies.
3966-
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
3965+
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
39673966
It requires using the OVN-Kubernetes network plugin with the Observability feature.
39683967
IMPORTANT: This feature is available as a Technology Preview.<br>
39693968
- `PacketTranslation`: Enable enriching flows with packet translation information, such as Service NAT.<br>
39703969
- `EbpfManager`: [Unsupported (*)]. Use eBPF Manager to manage NetObserv eBPF programs. Pre-requisite: the eBPF Manager operator (or upstream bpfman operator) must be installed.<br>
39713970
- `UDNMapping`: Enable interfaces mapping to User Defined Networks (UDN). <br>
3972-
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
3971+
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
39733972
It requires using the OVN-Kubernetes network plugin with the Observability feature. <br>
39743973
- `IPSec`, to track flows between nodes with IPsec encryption. <br>
39753974
items:
@@ -4557,7 +4556,7 @@ spec:
45574556
description: |-
45584557
`advanced` allows setting some aspects of the internal configuration of the console plugin.
45594558
This section is aimed mostly for debugging and fine-grained performance optimizations,
4560-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
4559+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
45614560
properties:
45624561
args:
45634562
description: |-
@@ -7111,7 +7110,7 @@ spec:
71117110
description: |-
71127111
`advanced` allows setting some aspects of the internal configuration of the flow processor.
71137112
This section is aimed mostly for debugging and fine-grained performance optimizations,
7114-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
7113+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
71157114
properties:
71167115
conversationEndTimeout:
71177116
default: 10s

bundle/manifests/netobserv-operator.clusterserviceversion.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ metadata:
435435
categories: Monitoring, Networking, Observability
436436
console.openshift.io/plugins: '["netobserv-plugin"]'
437437
containerImage: quay.io/netobserv/network-observability-operator:1.8.2-community
438-
createdAt: "2025-06-16T15:06:19Z"
438+
createdAt: "2025-06-23T09:16:32Z"
439439
description: Network flows collector and monitoring solution
440440
operatorframework.io/initialization-resource: '{"apiVersion":"flows.netobserv.io/v1beta2",
441441
"kind":"FlowCollector","metadata":{"name":"cluster"},"spec": {}}'

config/crd/bases/flows.netobserv.io_flowcollectors.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2650,7 +2650,7 @@ spec:
26502650
description: |-
26512651
`advanced` allows setting some aspects of the internal configuration of the eBPF agent.
26522652
This section is aimed mostly for debugging and fine-grained performance optimizations,
2653-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk. You can also
2653+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk. You can also
26542654
override the default Linux capabilities from there.
26552655
properties:
26562656
capOverride:
@@ -3638,18 +3638,17 @@ spec:
36383638
description: |-
36393639
List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br>
36403640
- `PacketDrop`: Enable the packets drop flows logging feature. This feature requires mounting
3641-
the kernel debug filesystem, so the eBPF agent pods must run as privileged.
3642-
If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
3641+
the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.<br>
36433642
- `DNSTracking`: Enable the DNS tracking feature.<br>
36443643
- `FlowRTT`: Enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
36453644
- `NetworkEvents`: Enable the network events monitoring feature, such as correlating flows and network policies.
3646-
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
3645+
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
36473646
It requires using the OVN-Kubernetes network plugin with the Observability feature.
36483647
IMPORTANT: This feature is available as a Technology Preview.<br>
36493648
- `PacketTranslation`: Enable enriching flows with packet translation information, such as Service NAT.<br>
36503649
- `EbpfManager`: [Unsupported (*)]. Use eBPF Manager to manage NetObserv eBPF programs. Pre-requisite: the eBPF Manager operator (or upstream bpfman operator) must be installed.<br>
36513650
- `UDNMapping`: Enable interfaces mapping to User Defined Networks (UDN). <br>
3652-
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
3651+
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
36533652
It requires using the OVN-Kubernetes network plugin with the Observability feature. <br>
36543653
- `IPSec`, to track flows between nodes with IPsec encryption. <br>
36553654
items:
@@ -4176,7 +4175,7 @@ spec:
41764175
description: |-
41774176
`advanced` allows setting some aspects of the internal configuration of the console plugin.
41784177
This section is aimed mostly for debugging and fine-grained performance optimizations,
4179-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
4178+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
41804179
properties:
41814180
args:
41824181
description: |-
@@ -6515,7 +6514,7 @@ spec:
65156514
description: |-
65166515
`advanced` allows setting some aspects of the internal configuration of the flow processor.
65176516
This section is aimed mostly for debugging and fine-grained performance optimizations,
6518-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
6517+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
65196518
properties:
65206519
conversationEndTimeout:
65216520
default: 10s

docs/FlowCollector.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6204,7 +6204,7 @@ is set to `eBPF`.
62046204
<td>
62056205
`advanced` allows setting some aspects of the internal configuration of the eBPF agent.
62066206
This section is aimed mostly for debugging and fine-grained performance optimizations,
6207-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk. You can also
6207+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk. You can also
62086208
override the default Linux capabilities from there.<br/>
62096209
</td>
62106210
<td>false</td>
@@ -6249,18 +6249,17 @@ Otherwise it is matched as a case-sensitive string.<br/>
62496249
<td>
62506250
List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br>
62516251
- `PacketDrop`: Enable the packets drop flows logging feature. This feature requires mounting
6252-
the kernel debug filesystem, so the eBPF agent pods must run as privileged.
6253-
If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
6252+
the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.<br>
62546253
- `DNSTracking`: Enable the DNS tracking feature.<br>
62556254
- `FlowRTT`: Enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
62566255
- `NetworkEvents`: Enable the network events monitoring feature, such as correlating flows and network policies.
6257-
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
6256+
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
62586257
It requires using the OVN-Kubernetes network plugin with the Observability feature.
62596258
IMPORTANT: This feature is available as a Technology Preview.<br>
62606259
- `PacketTranslation`: Enable enriching flows with packet translation information, such as Service NAT.<br>
62616260
- `EbpfManager`: [Unsupported (*)]. Use eBPF Manager to manage NetObserv eBPF programs. Pre-requisite: the eBPF Manager operator (or upstream bpfman operator) must be installed.<br>
62626261
- `UDNMapping`: Enable interfaces mapping to User Defined Networks (UDN). <br>
6263-
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged.
6262+
This feature requires mounting the kernel debug filesystem, so the eBPF agent pods must run as privileged via `spec.agent.ebpf.privileged`.
62646263
It requires using the OVN-Kubernetes network plugin with the Observability feature. <br>
62656264
- `IPSec`, to track flows between nodes with IPsec encryption. <br><br/>
62666265
</td>
@@ -6361,7 +6360,7 @@ For more information, see https://kubernetes.io/docs/concepts/configuration/mana
63616360

63626361
`advanced` allows setting some aspects of the internal configuration of the eBPF agent.
63636362
This section is aimed mostly for debugging and fine-grained performance optimizations,
6364-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk. You can also
6363+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk. You can also
63656364
override the default Linux capabilities from there.
63666365

63676366
<table>
@@ -8966,7 +8965,7 @@ refer to `forceSampleAll`. Alternatively, you can use the eBPF Agent instead of
89668965
<td>
89678966
`advanced` allows setting some aspects of the internal configuration of the console plugin.
89688967
This section is aimed mostly for debugging and fine-grained performance optimizations,
8969-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.<br/>
8968+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.<br/>
89708969
</td>
89718970
<td>false</td>
89728971
</tr><tr>
@@ -9055,7 +9054,7 @@ For more information, see https://kubernetes.io/docs/concepts/configuration/mana
90559054

90569055
`advanced` allows setting some aspects of the internal configuration of the console plugin.
90579056
This section is aimed mostly for debugging and fine-grained performance optimizations,
9058-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
9057+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
90599058

90609059
<table>
90619060
<thead>
@@ -14357,7 +14356,7 @@ This feature requires the "topology.kubernetes.io/zone" label to be set on nodes
1435714356
<td>
1435814357
`advanced` allows setting some aspects of the internal configuration of the flow processor.
1435914358
This section is aimed mostly for debugging and fine-grained performance optimizations,
14360-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.<br/>
14359+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.<br/>
1436114360
</td>
1436214361
<td>false</td>
1436314362
</tr><tr>
@@ -14502,7 +14501,7 @@ When a subnet matches the source or destination IP of a flow, a corresponding fi
1450214501

1450314502
`advanced` allows setting some aspects of the internal configuration of the flow processor.
1450414503
This section is aimed mostly for debugging and fine-grained performance optimizations,
14505-
such as `GOGC` and `GOMAXPROCS` env vars. Set these values at your own risk.
14504+
such as `GOGC` and `GOMAXPROCS` environment variables. Set these values at your own risk.
1450614505

1450714506
<table>
1450814507
<thead>

0 commit comments

Comments
 (0)