Commit 001b03c
committed
Restore test settings before after_suite to fix cross-suite leak
after_all ran after_suite before restoring the per-suite settings snapshot.
Suites that enable a setting in before_suite (e.g. test_rack_attack sets
enable_security) and do privileged cleanup in after_suite (deleting users)
then ran that teardown with the setting still active -> WriteAccessDeniedError.
Because after_suite raised, restore_settings never ran, so enable_security
leaked into every later suite (data-setup WriteAccessDenied, 401s on public
routes). Restore first so teardown runs with settings rolled back and a raising
after_suite cannot leak.1 parent ffadcd8 commit 001b03c
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
182 | 185 | | |
| 186 | + | |
183 | 187 | | |
184 | 188 | | |
185 | 189 | | |
| |||
0 commit comments