Refactor numberish function for improved readability and accuracy; update QueryStringTransformer methods to ensure parameter checks handle string values correctly

Author: ahosgood

tna_utilities/number.py

@@ -4,8 +4,12 @@
 def numberish(
     value: Union[float, int],
     simple_units: bool = False,
-    prefix_text: Union[str, tuple[str]] = "About ",
+    prefix_text: Union[str, tuple[str, str]] = "About ",
 ) -> str:
+    """
+    Convert a number into a human-readable string with appropriate units.
+    """
+
     if not isinstance(value, (int, float)):
         raise ValueError("Value must be an integer or float")
     if value == 0:
@@ -23,8 +27,8 @@ def numberish(
             base_value = value / threshold
             if base_value.is_integer():
                 return f"{int(base_value)}{unit}"
-            base_value_2sf = float(f"{base_value:.2g}")
-            if base_value_2sf == base_value:
+            base_value_rounded = float(f"{base_value:.2g}")
+            if base_value_rounded == base_value:
                 prefix_text = ""
             elif isinstance(prefix_text, tuple):
                 if len(prefix_text) != 2:
@@ -33,9 +37,8 @@ def numberish(
                     raise ValueError(
                         "Both elements of the prefix_text tuple must be strings"
                     )
+                is_approximation_high = base_value_rounded * threshold - value >= 0
                 prefix_text = (
-                    prefix_text[0]
-                    if base_value_2sf * threshold - value >= 0
-                    else prefix_text[1]
+                    prefix_text[0] if is_approximation_high else prefix_text[1]
                 )
-            return f"{prefix_text}{base_value_2sf:g}{unit}"
+            return f"{prefix_text}{base_value_rounded:g}{unit}"

tna_utilities/url.py

@@ -30,7 +30,10 @@ def parameter_exists(self, parameter) -> bool:
         Check if a parameter exists in the query parameters.
         """
 
-        return parameter in dict(self.args)
+        for key, _ in self.args:
+            if key == parameter:
+                return True
+        return False
 
     def parameter_values(self, parameter: str) -> list:
         """
@@ -123,7 +126,7 @@ def toggle_parameter_value(
 
         for key, values in self.args:
             if key == parameter:
-                if value in values:
+                if str(value) in values:
                     self.remove_parameter_value(parameter, value)
                 else:
                     self.add_parameter_value(parameter, value)
@@ -140,8 +143,8 @@ def remove_parameter_value(
 
         for key, values in self.args:
             if key == parameter:
-                if value in values:
-                    values.remove(value)
+                if str(value) in values:
+                    values.remove(str(value))
                 return self
         raise AttributeError(f"Parameter '{parameter}' does not exist")