Skip to content

Fixed a typo on Talk.php#116

Open
naifmhd wants to merge 4 commits into
nahid:masterfrom
naifmhd:master
Open

Fixed a typo on Talk.php#116
naifmhd wants to merge 4 commits into
nahid:masterfrom
naifmhd:master

Conversation

@naifmhd

@naifmhd naifmhd commented Mar 12, 2018

Copy link
Copy Markdown

the relationship was conversation but it was written as coversation.

@nahid nahid left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep $this->config instead of config

@ndhaked

ndhaked commented Jun 11, 2018

Copy link
Copy Markdown

i need to delete messages from one sided like as facebook delete for me only..

@nahid

nahid commented Jun 12, 2018

Copy link
Copy Markdown
Owner

One side soft delete feature is already implemented

@ndhaked

ndhaked commented Jun 14, 2018 via email

Copy link
Copy Markdown

@peter279k

Copy link
Copy Markdown

@ndhaked, I think that it doesn't matter.
Just add the latest commit to fix $this->config request changes as @nahid says.
The Git can squash all to one commit and it can also use the merging approach when merging the PR.

Thanks.

@cfpinto

cfpinto commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

@naifmhd could you please do the changes that @nahid requested? We would like to merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants