fix(qa): ISSUE-PR3 — parseYear preserves zero and full years

Author: Matt Schwar

CURRENT_STATE.md

@@ -64,7 +64,7 @@ Status below reflects the current local verification pass.
 
 ## Known Risks
 
-- The dashboard loads D3 from a CDN, so the browser smoke harness is a preflight rather than an offline-safe guarantee.
+- The dashboard is offline-safe and loads local manifest/CSV assets instead of a remote D3 CDN.
 - Some plot rows remain speculative or projection-based and should not be reworded into facts without source review.
 - Generated outputs need to be rebuilt after data or source edits to stay fresh.
 - The repo depends on the Python packages listed in `requirements.txt`.
@@ -79,7 +79,7 @@ Status below reflects the current local verification pass.
 
 ## Handoff Note
 
-- Changed: the unified dashboard now loads only local assets and renders with inline SVG instead of a remote D3 CDN.
-- Verified by: `python -m pytest tests/test_dashboard.py tests/test_browser_smoke.py -q`, `python scripts/browser_smoke.py`, and browser QA after serving the repo locally.
-- Remaining risk: the browser smoke harness is still a preflight check; the real browser pass remains the proof for visual behavior.
+- Changed: the unified dashboard now loads only local assets and renders with inline SVG instead of a remote D3 CDN; the year parser now preserves zero-valued years and full-width year strings.
+- Verified by: `python -m pytest tests/test_dashboard.py tests/test_dashboard_year_parsing.py tests/test_browser_smoke.py -q`, `python scripts/browser_smoke.py`, and browser QA screenshots on the live Pages site.
+- Evidence: `.gstack/qa-reports/screenshots/dashboard-desktop.png`, `.gstack/qa-reports/screenshots/dashboard-mobile.png`, `.gstack/qa-reports/screenshots/homepage-desktop.png`.
 - Next feature: provenance coverage for speculative rows.

dashboard/dashboard.js

@@ -175,15 +175,15 @@ function loadCSV(url) {
 }
 
 function parseYear(row) {
-  const raw = row.year || row.Year || row.Years_Ago || row.date;
-  if (!raw) {
+  const raw = row.year ?? row.Year ?? row.Years_Ago ?? row.date;
+  if (raw === null || raw === undefined || raw === '') {
     return null;
   }
-  if (row.Years_Ago) {
-    const yearsAgo = Number.parseFloat(raw);
+  if (row.Years_Ago !== undefined && row.Years_Ago !== null && row.Years_Ago !== '') {
+    const yearsAgo = Number.parseFloat(String(raw).trim());
     return Number.isFinite(yearsAgo) ? 2026 - yearsAgo : null;
   }
-  const parsed = Number.parseFloat(String(raw).slice(0, 4));
+  const parsed = Number.parseFloat(String(raw).trim());
   return Number.isFinite(parsed) ? parsed : null;
 }
 

tests/test_dashboard_year_parsing.py

@@ -0,0 +1,65 @@
+"""Regression tests for dashboard year parsing."""
+
+from __future__ import annotations
+
+import json
+import subprocess
+from pathlib import Path
+
+DASHBOARD_JS = Path("dashboard/dashboard.js")
+
+
+def _extract_function(source: str, signature: str) -> str:
+    start = source.index(signature)
+    brace_depth = 0
+    end = None
+
+    for index in range(start, len(source)):
+        char = source[index]
+        if char == "{":
+            brace_depth += 1
+        elif char == "}":
+            brace_depth -= 1
+            if brace_depth == 0:
+                end = index + 1
+                break
+
+    assert end is not None, f"Could not extract function for {signature}"
+    return source[start:end]
+
+
+def test_parse_year_preserves_zero_and_full_year_values():
+    """Regression: ISSUE-PR3 — parseYear treated 0 as falsy and truncated long years.
+
+    Found by /qa on 2026-05-20
+    Report: .gstack/qa-reports/qa-report-plots-2026-05-20.md
+    """
+
+    source = DASHBOARD_JS.read_text()
+    parse_year = _extract_function(source, "function parseYear(row) {")
+
+    cases = [
+        {"row": {"year": 0}, "expected": 0},
+        {"row": {"Year": 12345}, "expected": 12345},
+        {"row": {"date": "2024-01-01"}, "expected": 2024},
+        {"row": {"Years_Ago": 2}, "expected": 2024},
+        {"row": {"year": ""}, "expected": None},
+    ]
+
+    script = "\n".join(
+        [
+            parse_year,
+            f"const cases = {json.dumps([case['row'] for case in cases])};",
+            "const results = cases.map((row) => parseYear(row));",
+            "process.stdout.write(JSON.stringify(results));",
+        ]
+    )
+
+    completed = subprocess.run(
+        ["node", "-e", script],
+        check=True,
+        capture_output=True,
+        text=True,
+    )
+
+    assert json.loads(completed.stdout) == [case["expected"] for case in cases]