using aggregate-add-third-party is not working when packaging is pom even I have set acceptPomPackaging as true

[ma345564280]

I have set acceptPomPackaging as true, but still got the following message.

[INFO] --- license:2.4.0:aggregate-add-third-party (default-cli) @ xxxxxx ---
ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console...
[INFO] The goal is skip due to packaging 'jar'
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.812 s
[INFO] Finished at: 2024-09-06T17:27:40+08:00
[INFO] ------------------------------------------------------------------------

[ma345564280]

add-third-party is working

[slawekjaranowski]

There is a method org.codehaus.mojo.license.AbstractLicenseMojo#checkPackaging
It is override by:

• org.codehaus.mojo.license.AddThirdPartyMojo#checkPackaging
• org.codehaus.mojo.license.AggregatorAddThirdPartyMojo#checkPackaging

Fixing and write tests for it should not be difficult.

[vitalijr2]

I have multi-module project, parent is "pom" and children are "jar".

I run ./mvnw license:aggregate-add-third-party, the log is:

[INFO] 
[INFO] --- license:2.4.0:aggregate-add-third-party (default-cli) @ some-project ---
[INFO] The default plugin hint is: org.codehaus.mojo:license-maven-plugin:2.4.0:add-third-party
[INFO] Detected 3 license(s).
[INFO] Writing third-party file to some-project/THIRD-PARTY.txt
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Some Project 1.0.0:
[INFO] 
[INFO] Some Project ....................................... SUCCESS [  0.876 s]
[INFO] First child .................. SKIPPED
[INFO] Second child ............ SKIPPED
[INFO] Third child .............. SKIPPED
[INFO] Fourth child ............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

The file THIRD-PARTY.txt look like:

Lists of 16 third-party dependencies.
     (Apache License version 2.0) Apache Commons Logging (commons-logging:commons-logging:1.3.4 - https://commons.apache.org/proper/commons-logging/)
...
     (Eclipse Public License - v 2.0) JUnit Jupiter API (org.junit.jupiter:junit-jupiter-api:5.11.3 - https://junit.org/junit5/)
     (Eclipse Public License - v 2.0) JUnit Jupiter Engine (org.junit.jupiter:junit-jupiter-engine:5.11.3 - https://junit.org/junit5/)
...
     (MIT License) SLF4J API Module (org.slf4j:slf4j-api:2.0.16 - http://www.slf4j.org)

[slawekjaranowski]

@vitalijr2 - is it ok or not
If not please provide a source of test project and show what result should be

[vitalijr2]

@slawekjaranowski It's OK.

I has been browsing issues and found this one. But I remember this goal had worked for me well. Then I ran the build again - it still worked.

Also I remember that one time I saw the message

[INFO] --- license:2.4.0:aggregate-add-third-party (default-cli) @ xxxxxx ---
ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console...

but now it doesn't appear. 😕 It is also OK, but maybe this issue throws in some special conditions or maybe misconfiguration.

@ma345564280, could you provide a test project? Tnx.