Skip to content

Commit ed314a7

Browse files
committed
Reword float_val check to the rule actually under test
The new ClientCustomHeaderNoMirrorNumber check asserts absence of a header for an *unannotated* parameter — the same designated-params-only rule the query check covers. The previous description stated a 'MUST NOT mirror number-typed params' requirement that SEP-2243 does not contain (the spec forbids the annotation on number, with rejection as the consequence; it does not define a client-side type filter). Reword the description and comment to the rule actually under test, keeping the number/SEP-2243 context as the explanatory why. Also trim the float_val schema description to match the sibling query param style.
1 parent 33e13c4 commit ed314a7

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/scenarios/client/http-custom-headers.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ export class HttpCustomHeadersScenario extends BaseHttpScenario {
321321
float_val: {
322322
type: 'number',
323323
description:
324-
'Floating point numeric value — no x-mcp-header annotation: the spec forbids x-mcp-header on `number`-typed properties, so this is sent in the body but never mirrored'
324+
'Floating point value — no x-mcp-header annotation, should not be mirrored'
325325
},
326326
non_ascii_val: {
327327
type: 'string',
@@ -475,17 +475,17 @@ export class HttpCustomHeadersScenario extends BaseHttpScenario {
475475
this.checkParamHeader(req, 'Method', args.method_val, 'string');
476476
}
477477

478-
// float_val is intentionally unannotated (the spec forbids x-mcp-header on
479-
// `number`-typed properties), so it MUST NOT be mirrored. Assert the absence,
480-
// mirroring the negative check applied to the unannotated `query` parameter.
478+
// float_val is intentionally unannotated: SEP-2243 forbids x-mcp-header on
479+
// `number`-typed properties, so it is served without one. Assert no header
480+
// was sent — same "designated params only" rule as the `query` check below.
481481
const floatHeader = req.headers['mcp-param-floatval'] as
482482
| string
483483
| undefined;
484484
this.checks.push({
485485
id: 'sep-2243-client-mirrors-designated-params',
486486
name: 'ClientCustomHeaderNoMirrorNumber',
487487
description:
488-
'Client MUST NOT add an Mcp-Param header for a `number`-typed parameter (x-mcp-header is not permitted on it)',
488+
'Client MUST NOT add Mcp-Param headers for parameters without x-mcp-header (number-typed float_val is served unannotated per SEP-2243)',
489489
status: floatHeader === undefined ? 'SUCCESS' : 'FAILURE',
490490
timestamp: new Date().toISOString(),
491491
errorMessage:

0 commit comments

Comments
 (0)