fix: The App version is now defined as an env variable

Author: mightea

.github/workflows/publish-image.yml

@@ -39,17 +39,13 @@ jobs:
           node-version: 20
           cache: pnpm
 
-      - name: Update package.json version
-        run: |
-          node -e "const fs = require('fs'); const pkg = JSON.parse(fs.readFileSync('package.json','utf8')); pkg.version = process.env.PACKAGE_VERSION; fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n');"
-        env:
-          PACKAGE_VERSION: ${{ steps.gitversion.outputs.semVer }}
-
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
       - name: Build application
         run: pnpm build
+        env:
+          APP_VERSION: ${{ steps.gitversion.outputs.semVer }}
 
       - name: Log in to GitHub Container Registry
         uses: docker/login-action@v3
@@ -74,3 +70,5 @@ jobs:
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
+          build-args: |
+            APP_VERSION=${{ steps.gitversion.outputs.semVer }}

Dockerfile

@@ -5,13 +5,16 @@ RUN mkdir -p $PNPM_HOME && corepack enable && corepack prepare pnpm@10.2.1 --act
 WORKDIR /app
 
 FROM base AS builder
+ARG APP_VERSION=0.0.0
+ENV APP_VERSION=$APP_VERSION
 COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
 RUN pnpm install --frozen-lockfile
 COPY . .
 RUN pnpm build
 RUN pnpm prune --prod
 
 FROM node:22-alpine AS runtime
+ARG APP_VERSION=0.0.0
 ENV NODE_ENV=production
 ENV PNPM_HOME=/pnpm
 ENV PATH=$PNPM_HOME:$PATH
@@ -20,6 +23,7 @@ RUN mkdir -p $PNPM_HOME \
   && corepack prepare pnpm@10.2.1 --activate \
   && apk add --no-cache poppler-utils
 WORKDIR /app
+ENV APP_VERSION=$APP_VERSION
 COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
 COPY --from=builder /app/node_modules ./node_modules
 COPY --from=builder /app/build ./build

app/routes/settings.tsx

@@ -2,7 +2,6 @@ import { useEffect } from "react";
 import { data, useLoaderData, useFetcher } from "react-router";
 import { eq } from "drizzle-orm";
 import path from "node:path";
-import { readFile } from "node:fs/promises";
 
 import {
   Card,
@@ -106,12 +105,7 @@ export async function loader({ request }: Route.LoaderArgs) {
   const { user, headers } = await requireUser(request);
   const db = await getDb();
 
-  const packageJsonRaw = await readFile(
-    new URL("../../package.json", import.meta.url),
-    "utf-8",
-  );
-  const packageMetadata = JSON.parse(packageJsonRaw) as { version?: string };
-  const APP_VERSION = packageMetadata.version ?? "0.0.0";
+  const APP_VERSION = process.env.APP_VERSION ?? "0.0.0";
 
   const isAdmin = user.role === "admin";
   const [locationResult, currencyResult, usersList] = await Promise.all([