Milkdown Editor (#459)

Author: DavidKoleczek

libraries/python/assistant-extensions/assistant_extensions/document_editor/_inspector.py

@@ -123,13 +123,14 @@ async def get(self, context: ConversationContext) -> AssistantConversationInspec
         if not document:
             return AssistantConversationInspectorStateDataModel(data={"content": "No current document."})
 
+        is_readonly = await self._controller.is_read_only(context)
+
         return AssistantConversationInspectorStateDataModel(
-            data=document.model_dump(mode="json"),
-            json_schema=document.model_json_schema(),
-            ui_schema=_get_document_editor_ui_schema(
-                await self._controller.is_read_only(context),
-                await self._controller.list_documents(context),
-            ),
+            data={
+                "markdown_content": document.content,
+                "filename": document.filename,
+                "readonly": is_readonly,
+            }
         )
 
     async def set(
@@ -142,13 +143,18 @@ async def set(
         if await self._controller.is_read_only(context):
             return
 
-        try:
-            model = DocumentFileStateModel.model_validate(data)
-        except ValidationError:
-            logger.exception("invalid data for DocumentFileStateModel")
-            return
-
-        await self._controller.write_active_document(context, model.content)
+        # The data comes in with 'markdown_content' but our model expects 'content'
+        if "markdown_content" in data:
+            content = data["markdown_content"]
+            # If filename is present but we don't need to modify it, we can just get the content
+            await self._controller.write_active_document(context, content)
+        else:
+            try:
+                model = DocumentFileStateModel.model_validate(data)
+                await self._controller.write_active_document(context, model.content)
+            except ValidationError:
+                logger.exception("invalid data for DocumentFileStateModel")
+                return
 
 
 class ReadonlyDocumentFileStateInspector:
@@ -189,7 +195,11 @@ async def get(self, context: ConversationContext) -> AssistantConversationInspec
             return AssistantConversationInspectorStateDataModel(data={"content": "No current document."})
 
         return AssistantConversationInspectorStateDataModel(
-            data={"content": f"```markdown\n_Filename: {document.filename}_\n\n{document.content}\n```"}
+            data={
+                "markdown_content": document.content,
+                "filename": document.filename,
+                "readonly": True,  # Always read-only for this inspector
+            },
         )
 
 

workbench-app/.vscode/settings.json

@@ -185,6 +185,7 @@
         "levelname",
         "levelno",
         "listbox",
+        "Milkdown",
         "msal",
         "multimodel",
         "nonchat",

workbench-app/package.json

@@ -38,6 +38,10 @@
         "@lexical/utils": "^0.17.1",
         "@microsoft/fetch-event-source": "^2.0.1",
         "@microsoft/microsoft-graph-client": "^3.0.7",
+        "@milkdown/crepe": "^7.7.0",
+        "@milkdown/kit": "^7.7.0",
+        "@milkdown/react": "^7.7.0",
+        "@milkdown/theme-nord": "^7.7.0",
         "@reduxjs/toolkit": "^1.9.7",
         "@rjsf/core": "^5.21.1",
         "@rjsf/fluentui-rc": "^5.21.1",