Skip to content

chore(deps): migrate to golangci-lint v2#1494

Merged
nddq merged 3 commits into
mainfrom
deps/golangci-lintv2
Jul 28, 2025
Merged

chore(deps): migrate to golangci-lint v2#1494
nddq merged 3 commits into
mainfrom
deps/golangci-lintv2

Conversation

@nddq

@nddq nddq commented Mar 29, 2025

Copy link
Copy Markdown
Member

Description

As title

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@nddq nddq added area/dependencies Pull requests that update a dependency file area/infra Test, Release, or CI Infrastructure labels Mar 29, 2025
@nddq nddq self-assigned this Mar 29, 2025
@nddq nddq requested a review from a team as a code owner March 29, 2025 17:05
@matmerr

matmerr commented Apr 1, 2025

Copy link
Copy Markdown
Member

was this done with the migrate command?

also can you double check this doesn't break the make fmt recipe? looks like there's a new golangci-lint fmt cmd which may need to be updated in the makefile

@nddq

nddq commented Apr 2, 2025

Copy link
Copy Markdown
Member Author

was this done with the migrate command?

yes

also can you double check this doesn't break the make fmt recipe? looks like there's a new golangci-lint fmt cmd which may need to be updated in the makefile

make fmt still works. I cross checked make fmt results and golangci-lint fmt results and they are identical.

@github-actions

github-actions Bot commented May 3, 2025

Copy link
Copy Markdown

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions Bot added the meta/waiting-for-author Blocked and waiting on the author label May 3, 2025
@nddq nddq removed the meta/waiting-for-author Blocked and waiting on the author label May 4, 2025
@nddq nddq requested review from matmerr and removed request for alexcastilio and rectified95 May 30, 2025 19:50
@nddq nddq enabled auto-merge May 31, 2025 16:33
@github-actions

Copy link
Copy Markdown

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions Bot added the meta/waiting-for-author Blocked and waiting on the author label Jun 30, 2025
@nddq nddq removed the meta/waiting-for-author Blocked and waiting on the author label Jun 30, 2025
@nddq nddq force-pushed the deps/golangci-lintv2 branch from 1f8d703 to 5acfac6 Compare June 30, 2025 16:41
nddq added 3 commits July 18, 2025 02:27
Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
@nddq nddq force-pushed the deps/golangci-lintv2 branch from 5acfac6 to c986c12 Compare July 18, 2025 06:28

@SRodi SRodi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nddq nddq added this pull request to the merge queue Jul 28, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 28, 2025
@nddq nddq added this pull request to the merge queue Jul 28, 2025
Merged via the queue into main with commit bceac9c Jul 28, 2025
31 checks passed
@nddq nddq deleted the deps/golangci-lintv2 branch July 28, 2025 16:10
mereta pushed a commit that referenced this pull request Dec 2, 2025
# Description

As title
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file area/infra Test, Release, or CI Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants