From 921a75171a0d9a680a2d809442ce6b3ea0c6e0a0 Mon Sep 17 00:00:00 2001 From: Pedro Henrique Penna Date: Wed, 23 Sep 2026 20:54:36 -0700 Subject: [PATCH 1/2] release: reject boolean asset sizes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- scripts/test_nvx_tools.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/test_nvx_tools.py b/scripts/test_nvx_tools.py index f8f7eeb2..aab6088b 100644 --- a/scripts/test_nvx_tools.py +++ b/scripts/test_nvx_tools.py @@ -7284,6 +7284,11 @@ def test_selects_latest_matching_prerelease_asset(self): "prerelease": True, "tag_name": "v1.2.3-dev.abc123", "assets": [ + { + "name": "nvx-invalid-linux-kvm.tar.gz", + "url": "https://api.example.invalid/invalid", + "size": True, + }, { "name": "nvx-1.2.3-windows-whp.zip", "url": "https://api.example.invalid/windows", From cbfdc7f1157e728309208c43919e7b53cbe85701 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 26 Sep 2026 19:14:38 +0000 Subject: [PATCH 2/2] release: reject boolean asset sizes Co-authored-by: ppenna <4939789+ppenna@users.noreply.github.com> --- scripts/nvx_tools/release.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/nvx_tools/release.py b/scripts/nvx_tools/release.py index e5766981..393af036 100644 --- a/scripts/nvx_tools/release.py +++ b/scripts/nvx_tools/release.py @@ -213,6 +213,7 @@ def _latest_release_asset( and asset_pattern.fullmatch(name) is not None and isinstance(asset_url, str) and isinstance(size, int) + and not isinstance(size, bool) ): return _ReleaseAsset(tag, name, asset_url, size) raise ScriptError(f"no GitHub release contains an NVX package for {platform}")