Skip to content

Commit e1bf02c

Browse files
committed
Merge pull request #599 from mousetraps/i598
#598 remove docker publish hooks
2 parents 0643875 + e1abd72 commit e1bf02c

5 files changed

Lines changed: 4 additions & 41 deletions

File tree

Nodejs/Product/Nodejs/Nodejs.csproj

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -901,10 +901,6 @@
901901
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
902902
<IncludeInVSIX>true</IncludeInVSIX>
903903
</Content>
904-
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile" />
905-
<VSIXSourceItem Include="Templates\Files\DockerfileTemplate\Dockerfile">
906-
<VSIXSubPath>FileTemplates\ReferenceFiles\Dockerfile</VSIXSubPath>
907-
</VSIXSourceItem>
908904
<None Include="Theme\contrast.vstheme">
909905
<SubType>Designer</SubType>
910906
</None>
@@ -1305,9 +1301,6 @@
13051301
<SubType>Designer</SubType>
13061302
</ZipItem>
13071303
<ZipItem Include="Templates\Files\UnitTest\UnitTest.js" />
1308-
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile.vstemplate">
1309-
<SubType>Designer</SubType>
1310-
</ZipItem>
13111304
<Content Include="TestFrameworks\find_tests.js">
13121305
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
13131306
<IncludeInVSIX>true</IncludeInVSIX>
@@ -1331,6 +1324,10 @@
13311324
<ZipItem Include="Templates\Files\TypeScriptUnitTest\UnitTest.vstemplate">
13321325
<SubType>Designer</SubType>
13331326
</ZipItem>
1327+
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile" />
1328+
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile.vstemplate">
1329+
<SubType>Designer</SubType>
1330+
</ZipItem>
13341331
<None Include="Theme\Microsoft.NodejsTools.theme.v11.0.pkgdef" />
13351332
<None Include="Theme\Microsoft.NodejsTools.theme.v12.0.pkgdef" />
13361333
<None Include="Theme\Microsoft.NodejsTools.theme.v14.0.pkgdef" />
@@ -1756,7 +1753,6 @@
17561753
</Target>
17571754
<PropertyGroup>
17581755
<PostBuildEvent>
1759-
echo f | xcopy /y $(ProjectDir)Templates\Files\DockerfileTemplate\Dockerfile $(OutDir)FileTemplates\ReferenceFiles\Dockerfile
17601756
copy /y $(OutDir)..\WebRole\Microsoft.NodejsTools.WebRole.dll $(OutDir)Debugger\RemoteDebug\
17611757
</PostBuildEvent>
17621758
</PropertyGroup>

Nodejs/Product/Nodejs/Project/NodejsProjectNode.cs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -379,25 +379,6 @@ protected override NodeProperties CreatePropertiesObject() {
379379
return new NodejsProjectNodeProperties(this);
380380
}
381381

382-
public override int GetPropertyValue(string propertyName, string configName, uint storage, out string propertyValue) {
383-
propertyValue = null;
384-
switch (propertyName) {
385-
case "DockerLinuxDockerfileContents":
386-
propertyValue = DockerfileWizardExtension.GetDockerfileWithReplacements(
387-
File.ReadAllText(@"FileTemplates\ReferenceFiles\Dockerfile"),
388-
DTE
389-
);
390-
return VSConstants.S_OK;
391-
case "DockerAppType":
392-
propertyValue = "Node.js";
393-
return VSConstants.S_OK;
394-
case "DockerDefaultPublishContainerPort":
395-
propertyValue = "8080";
396-
return VSConstants.S_OK;
397-
}
398-
return base.GetPropertyValue(propertyName, configName, storage, out propertyValue);
399-
}
400-
401382
protected override Stream ProjectIconsImageStripStream {
402383
get {
403384
return typeof(ProjectNode).Assembly.GetManifestResourceStream("Microsoft.VisualStudioTools.Resources.Icons.SharedProjectImageList.bmp");

Nodejs/Product/ProjectWizard/DockerfileWizardExtension.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,9 @@
1616

1717
using System;
1818
using System.Collections.Generic;
19-
using System.Diagnostics;
2019
using EnvDTE;
2120
using Microsoft.VisualStudio.TemplateWizard;
2221
using Microsoft.VisualStudioTools;
23-
using System.IO;
24-
using System.Windows.Forms;
25-
using System.Text.RegularExpressions;
2622

2723
namespace Microsoft.NodejsTools.ProjectWizard {
2824
/// <summary>
@@ -51,11 +47,6 @@ public void RunStarted(object automationObject, Dictionary<string, string> repla
5147
replacementsDictionary.Add("$nodearguments$", arguments);
5248
}
5349

54-
public static string GetDockerfileWithReplacements(string dockerFileContents, DTE dte) {
55-
string arguments = GetFullNodeArguments(dte);
56-
return dockerFileContents.Replace("$nodearguments$", arguments);
57-
}
58-
5950
private static string GetFullNodeArguments(object automationObject) {
6051
string arguments = null;
6152
if (automationObject is DTE) {

Nodejs/Setup/NodejsTools/NodejsTools.wxs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<DirectoryRef Id="Dir_$(var.key)InstallLocation">
1212
<Directory Id="Dir_$(var.key)InstallLocationFileTemplates" Name="FileTemplates">
1313
<Directory Id="Dir_$(var.key)FileTemplatesNewItem" Name="NewItem" />
14-
<Directory Id="Dir_$(var.key)FileTemplatesReferenceFiles" Name="ReferenceFiles" />
1514
</Directory>
1615
<Directory Id="Dir_$(var.key)TestFrameworks" Name="TestFrameworks">
1716
<Directory Id="Dir_$(var.key)TestFrameworksExportRunner" Name="ExportRunner" />

Nodejs/Setup/NodejsTools/NodejsToolsFiles.proj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@
5555

5656
<InstallDirectory>FileTemplatesNewItem</InstallDirectory>
5757
</File>
58-
59-
<File Include="FileTemplates\ReferenceFiles\Dockerfile">
60-
<InstallDirectory>FileTemplatesReferenceFiles</InstallDirectory>
61-
</File>
6258

6359
<ItemTemplate Include="ItemTemplates\JavaScript\UnitTest.zip;
6460
ItemTemplates\JavaScript\MochaUnitTest.zip;

0 commit comments

Comments
 (0)