Skip to content

Add MockIpmiBootOptionLib for GoogleTest#369

Merged
apop5 merged 2 commits into
microsoft:mainfrom
TsunFengHuang:user/TsunFeng/add-MockIpmiBootOptionLib
Apr 22, 2026
Merged

Add MockIpmiBootOptionLib for GoogleTest#369
apop5 merged 2 commits into
microsoft:mainfrom
TsunFengHuang:user/TsunFeng/add-MockIpmiBootOptionLib

Conversation

@TsunFengHuang

@TsunFengHuang TsunFengHuang commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Description

Add mock library for IpmiBootOptionLib to support GoogleTest-based unit testing.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Pipeline Test Pass
Unit tests component can call these mock functions success

Integration Instructions

N/A

Add GoogleTest mock library for IpmiBootOptionLib, mocking
IpmiGetBootDevice and IpmiGetCmosClearOption functions.

Follows the existing three-file mock pattern (header, cpp, inf)
matching MockIpmiSelLib, MockIpmiCommandLib, and MockIpmiBaseLib.
@TsunFengHuang TsunFengHuang force-pushed the user/TsunFeng/add-MockIpmiBootOptionLib branch from b386f26 to b34472d Compare April 20, 2026 09:02
@mu-automation mu-automation Bot added impact:testing Affects testing impact:non-functional Does not have a functional impact labels Apr 20, 2026
Add MockIpmiBootOptionLib.inf to the [Components] section of
IpmiFeaturePkgHostTest.dsc to fix the Host Unit Test Dsc Complete
Check failure.
@codecov-commenter

codecov-commenter commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.31%. Comparing base (6442205) to head (3b6a8df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   28.31%   28.31%           
=======================================
  Files          41       41           
  Lines        3118     3118           
  Branches      405      405           
=======================================
  Hits          883      883           
  Misses       2223     2223           
  Partials       12       12           
Flag Coverage Δ
IpmiFeaturePkg 28.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TsunFengHuang TsunFengHuang marked this pull request as ready for review April 20, 2026 10:56
@cfernald cfernald requested review from apop5 and cfernald April 21, 2026 23:31
@TsunFengHuang

Copy link
Copy Markdown
Contributor Author

Hi @apop5
Could you help review this PR when you have a moment?
Thank you!

@apop5 apop5 merged commit 5defa30 into microsoft:main Apr 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact impact:testing Affects testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants