Bug Fix - Fix checkpointing#87
Open
chhwang wants to merge 1 commit into
Open
Conversation
yzygitzh
reviewed
Dec 20, 2025
| """Returns size in bytes of a given sharded tensor.""" | ||
| if sh_ten.flattened_range is None: | ||
| numel = np.product(sh_ten.local_shape) | ||
| numel = np.prod(sh_ten.local_shape) |
Contributor
There was a problem hiding this comment.
Is this due to that np.product is deprecated? Can we make this unchanged?
yzygitzh
reviewed
Dec 20, 2025
| # Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved. | ||
|
|
||
| """ Storage writer for PyT Distributed format allowing asynchronous save. """ | ||
| """Storage writer for PyT Distributed format allowing asynchronous save.""" |
Contributor
There was a problem hiding this comment.
This is not related to bug fix, shall we drop it?
yzygitzh
reviewed
Dec 20, 2025
| if "serialization_format" in inspect.signature(_write_item).parameters: | ||
| from torch.distributed.checkpoint.filesystem import SerializationFormat | ||
|
|
||
| extra_kwargs['serialization_format'] = SerializationFormat.TORCH_SAVE |
Contributor
There was a problem hiding this comment.
Previously there is no issue here, is this due to an upgrade of PyTorch? Shall we put the reason of change in PR description
|
Marking as stale. No activity in 60 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.