Replace existing Go detector with Go117 detector#1426
Merged
Conversation
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
=======================================
- Coverage 89.7% 89.5% -0.3%
=======================================
Files 407 404 -3
Lines 32379 31978 -401
Branches 2000 1994 -6
=======================================
- Hits 29072 28629 -443
- Misses 2881 2935 +54
+ Partials 426 414 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grvillic
reviewed
Jun 9, 2025
grvillic
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GoComponentDetector.csGo117ComponentDetector.csGoComponentDetectorTests.csgo mod graphwere mocking go list output. This was changed to mockgo.modparsing.Go117unit testsGoModParser.cs: This parser wasn't handling replace directives likego listwould have.