Address PR comments

Author: jpinz

src/Microsoft.ComponentDetection.Common/PatternMatchingUtility.cs

@@ -25,7 +25,7 @@ public static bool MatchesPattern(string pattern, string fileName)
         ArgumentNullException.ThrowIfNull(fileName);
         ArgumentNullException.ThrowIfNull(patterns);
 
-        return GetFirstMatchingPattern(fileName.AsSpan(), patterns);
+        return Compile(patterns).GetMatchingPattern(fileName.AsSpan());
     }
 
     public static CompiledMatcher Compile(IEnumerable<string> patterns)
@@ -40,24 +40,6 @@ public static CompiledMatcher Compile(string[] patterns)
         return new(patterns);
     }
 
-    private static string? GetFirstMatchingPattern(ReadOnlySpan<char> fileName, IEnumerable<string> patterns)
-    {
-        foreach (var pattern in patterns)
-        {
-            ArgumentNullException.ThrowIfNull(pattern);
-
-            if (IsPatternMatch(pattern, fileName))
-            {
-                return pattern;
-            }
-        }
-
-        return null;
-    }
-
-    /// <summary>
-    /// Fast path for pre-validated pattern arrays. Skips per-element null checks.
-    /// </summary>
     private static string? GetFirstMatchingPattern(ReadOnlySpan<char> fileName, string[] patterns)
     {
         foreach (var pattern in patterns)
@@ -99,7 +81,7 @@ internal CompiledMatcher(string[] patterns)
         /// <returns>The first matching pattern, or <see langword="null"/> if no patterns match.</returns>
         public string? GetMatchingPattern(ReadOnlySpan<char> fileName) => GetFirstMatchingPattern(fileName, this.patterns);
 
-        private static void ValidatePatternElements(IEnumerable<string> patterns)
+        private static void ValidatePatternElements(string[] patterns)
         {
             foreach (var pattern in patterns)
             {

src/Microsoft.ComponentDetection.Contracts/FileComponentDetector.cs

@@ -35,7 +35,7 @@ public abstract class FileComponentDetector : IComponentDetector
     public abstract string Id { get; }
 
     /// <summary>
-    /// Gets the search patterns used to produce the list of valid folders to scan.
+    /// Gets the search patterns used to produce the list of valid files to scan.
     /// The first pattern that matches a given file will be used to determine how that file is processed, so more specific patterns should be listed before more general ones. Wildcards are accepted.
     /// </summary>
     public abstract IList<string> SearchPatterns { get; }