Address PR comments.

Author: jpinz

src/Microsoft.ComponentDetection.Detectors/dockerfile/DockerfileComponentDetector.cs

@@ -4,7 +4,6 @@ namespace Microsoft.ComponentDetection.Detectors.Dockerfile;
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.ComponentDetection.Common;
@@ -116,7 +115,6 @@ private Task ParseDockerFileAsync(string fileContents, string fileLocation, ISin
 
     private DockerReference? ParseFromInstruction(DockerfileConstruct construct, char escapeChar, Dictionary<string, string> stageNameMap)
     {
-        var tokens = construct.Tokens.ToArray();
         var resolvedFromStatement = construct.ResolveVariables(escapeChar)?.TrimEnd();
         var fromInstruction = (FromInstruction)construct;
         var reference = fromInstruction.ImageName;

src/Microsoft.ComponentDetection.Detectors/helm/HelmComponentDetector.cs

@@ -97,9 +97,15 @@ protected override async Task OnFileFoundAsync(ProcessRequest processRequest, ID
         }
     }
 
+    /// <summary>
+    /// Checks if the given file name matches Helm chart file patterns (Chart.yaml or Chart.yml).
+    /// </summary>
+    /// <param name="fileName">The file name to check.</param>
+    /// <returns>True if the file name matches Helm chart file patterns; otherwise, false.</returns>
+    /// <remarks> The <c>C</c> in <c>Chart.yaml</c> is case-sensitive <see href="https://helm.sh/docs/chart_best_practices/conventions/#usage-of-the-words-helm-and-chart"/>.</remarks>
     private static bool IsChartFile(string fileName) =>
-        fileName.Equals("Chart.yaml", StringComparison.OrdinalIgnoreCase) ||
-        fileName.Equals("Chart.yml", StringComparison.OrdinalIgnoreCase);
+        fileName.Equals("Chart.yaml", StringComparison.Ordinal) ||
+        fileName.Equals("Chart.yml", StringComparison.Ordinal);
 
     private static bool IsValuesFile(string fileName) =>
         fileName.Contains("values", StringComparison.OrdinalIgnoreCase) &&

test/Microsoft.ComponentDetection.Detectors.Tests/HelmComponentDetectorTests.cs

@@ -405,6 +405,7 @@ public async Task TestHelm_LowercaseChartYamlAsync()
 version: 0.1.0
 ";
 
+        // Helm's Chart.yml file has to be named with an uppercase 'C'. Verify that files not matching this pattern are ignored.
         var (scanResult, componentRecorder) = await this.DetectorTestUtility
             .WithFile("chart.yaml", chartYaml)
             .ExecuteDetectorAsync();