Allow for null resolved version in package-lock.json (#1397)

JamieMagee · web-flow · commit 43a7487deacc · 2025-05-01T22:48:54.000Z
diff --git a/src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentUtilities.cs b/src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentUtilities.cs
@@ -43,7 +43,7 @@ public static TypedComponent GetTypedComponent(JProperty currentDependency, stri
     {
         var name = GetModuleName(currentDependency.Name);
 
-        var version = currentDependency.Value["version"].ToString();
+        var version = currentDependency.Value["version"]?.ToString();
         var hash = currentDependency.Value["integrity"]?.ToString(); // https://docs.npmjs.com/configuring-npm/package-lock-json.html#integrity
 
         if (!IsPackageNameValid(name))

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public static TypedComponent GetTypedComponent(JProperty currentDependency, stri`
`43`	`43`	`{`
`44`	`44`	`var name = GetModuleName(currentDependency.Name);`
`45`	`45`
`46`		`- var version = currentDependency.Value["version"].ToString();`
	`46`	`+ var version = currentDependency.Value["version"]?.ToString();`
`47`	`47`	`var hash = currentDependency.Value["integrity"]?.ToString(); // https://docs.npmjs.com/configuring-npm/package-lock-json.html#integrity`
`48`	`48`
`49`	`49`	`if (!IsPackageNameValid(name))`