Skip to content

Commit e6e6eb1

Browse files
jacob-ronstadtjacob-ronstadt
authored
update mustfix and recommended suites (#182)
1 parent 4700593 commit e6e6eb1

3 files changed

Lines changed: 95 additions & 25 deletions

File tree

‎src/qlpack.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Licensed under the MIT license.
33

44
name: microsoft/windows-drivers
5-
version: 1.6.0
5+
version: 1.7.0
66
dependencies:
77
codeql/cpp-all: ^4.2.0
88
microsoft/cpp-queries: ^0.0.4

‎src/windows-driver-suites/mustfix.qls‎

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,30 @@
1414
- include:
1515
query path:
1616
- Likely Bugs/Arithmetic/BadAdditionOverflowCheck.ql
17+
- Likely Bugs/Format/WrongNumberOfFormatArguments.ql
1718
- Likely Bugs/Memory Management/PointerOverflow.ql
19+
- Likely Bugs/Memory Management/SuspiciousCallToStrncat.ql
20+
- Likely Bugs/OO/UnsafeUseOfThis.ql
21+
- Likely Bugs/Protocols/TlsSettingsMisconfiguration.ql
22+
- Likely Bugs/Protocols/UseOfDeprecatedHardcodedProtocol.ql
1823
- Likely Bugs/Underspecified Functions/TooFewArguments.ql
24+
- Microsoft/Likely Bugs/Conversion/BadOverflowGuard.ql
25+
- Microsoft/Likely Bugs/Drivers/IncorrectUsageOfRtlCompareMemory.ql
26+
- Microsoft/Security/Cryptography/BannedEncryption.ql
27+
- Microsoft/Security/Cryptography/BannedModesCAPI.ql
28+
- Microsoft/Security/Cryptography/BannedModesCNG.ql
29+
- Microsoft/Security/Cryptography/HardcodedIVCNG.ql
30+
- Microsoft/Security/MemoryAccess/EnumIndex/UncheckedBoundsEnumAsIndex.ql
31+
- Security/CWE/CWE-078/ExecTainted.ql
32+
- Security/CWE/CWE-114/UncontrolledProcessOperation.ql
33+
- Security/CWE/CWE-120/BadlyBoundedWrite.ql
34+
- Security/CWE/CWE-120/OverrunWrite.ql
35+
- Security/CWE/CWE-131/NoSpaceForZeroTerminator.ql
36+
- Security/CWE/CWE-170/ImproperNullTerminationTainted.ql
1937
- Security/CWE/CWE-190/ComparisonWithWiderType.ql
20-
- Security/CWE/CWE-253/HResultBooleanConversion.ql
38+
- Security/CWE/CWE-253/HResultBooleanConversion.ql
39+
- Security/CWE/CWE-327/OpenSslHeartbleed.ql
40+
- Security/CWE/CWE-676/DangerousFunctionOverflow.ql
41+
- Security/CWE/CWE-676/DangerousUseOfCin.ql
42+
- Security/CWE/CWE-704/WcharCharConversion.ql
43+
- Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql

‎src/windows-driver-suites/recommended.qls‎

Lines changed: 70 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,73 @@
88
version: 0.0.4
99
- include:
1010
query path:
11-
- Likely Bugs/Format/WrongNumberOfFormatArguments.ql
12-
- Likely Bugs/Memory Management/SuspiciousCallToStrncat.ql
13-
- Likely Bugs/OO/UnsafeUseOfThis.ql
14-
- Likely Bugs/Protocols/TlsSettingsMisconfiguration.ql
15-
- Likely Bugs/Protocols/UseOfDeprecatedHardcodedProtocol.ql
16-
- Microsoft/Likely Bugs/Conversion/BadOverflowGuard.ql
17-
- Microsoft/Likely Bugs/Drivers/IncorrectUsageOfRtlCompareMemory.ql
18-
- Microsoft/Security/Cryptography/BannedEncryption.ql
19-
- Microsoft/Security/Cryptography/BannedModesCAPI.ql
20-
- Microsoft/Security/Cryptography/BannedModesCNG.ql
21-
- Microsoft/Security/Cryptography/HardcodedIVCNG.ql
22-
- Microsoft/Security/MemoryAccess/EnumIndex/UncheckedBoundsEnumAsIndex.ql
23-
- Security/CWE/CWE-078/ExecTainted.ql
24-
- Security/CWE/CWE-114/UncontrolledProcessOperation.ql
25-
- Security/CWE/CWE-120/BadlyBoundedWrite.ql
26-
- Security/CWE/CWE-120/OverrunWrite.ql
27-
- Security/CWE/CWE-131/NoSpaceForZeroTerminator.ql
28-
- Security/CWE/CWE-170/ImproperNullTerminationTainted.ql
29-
- Security/CWE/CWE-327/OpenSslHeartbleed.ql
30-
- Security/CWE/CWE-676/DangerousFunctionOverflow.ql
31-
- Security/CWE/CWE-676/DangerousUseOfCin.ql
32-
- Security/CWE/CWE-704/WcharCharConversion.ql
33-
- Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql
11+
- drivers/general/queries/AnnotationSyntax/AnnotationSyntax.ql
12+
- drivers/general/queries/CurrentFunctionTypeNotCorrect/CurrentFunctionTypeNotCorrect.ql
13+
- drivers/general/queries/DefaultPoolTag/DefaultPoolTag.ql
14+
- drivers/general/queries/DriverEntrySaveBuffer/DriverEntrySaveBuffer.ql
15+
- drivers/general/queries/ExaminedValue/ExaminedValue.ql
16+
- drivers/general/queries/ExtendedDeprecatedApis/ExtendedDeprecatedApis.ql
17+
- drivers/general/queries/IRPStackEntryCopy/IRPStackEntryCopy.ql
18+
- drivers/general/queries/ImportantFunctionCallOptimizedOut/ImportantFunctionCallOptimizedOut.ql
19+
- drivers/general/queries/ImproperNotOperatorOnZero/ImproperNotOperatorOnZero.ql
20+
- drivers/general/queries/InvalidFunctionClassTypedef/InvalidFunctionClassTypedef.ql
21+
- drivers/general/queries/InvalidFunctionPointerAnnotation/InvalidFunctionPointerAnnotation.ql
22+
- drivers/general/queries/IoInitializeTimerCall/IoInitializeTimerCall.ql
23+
- drivers/general/queries/IrqlAnnotationIssue/IrqlAnnotationIssue.ql
24+
- drivers/general/queries/IrqlCancelRoutine/IrqlCancelRoutine.ql
25+
- drivers/general/queries/IrqlFloatStateMismatch/IrqlFloatStateMismatch.ql
26+
- drivers/general/queries/IrqlNotSaved/IrqlNotSaved.ql
27+
- drivers/general/queries/IrqlNotUsed/IrqlNotUsed.ql
28+
- drivers/general/queries/IrqlSetTooHigh/IrqlSetTooHigh.ql
29+
- drivers/general/queries/IrqlSetTooLow/IrqlSetTooLow.ql
30+
- drivers/general/queries/IrqlTooHigh/IrqlTooHigh.ql
31+
- drivers/general/queries/IrqlTooLow/IrqlTooLow.ql
32+
- drivers/general/queries/KeSetEventPageable/KeSetEventPageable.ql
33+
- drivers/general/queries/MultithreadedAVCondition/MultithreadedAVCondition.ql
34+
- drivers/general/queries/NtstatusExplicitCast/NtstatusExplicitCast.ql
35+
- drivers/general/queries/NtstatusExplicitCast2/NtstatusExplicitCast2.ql
36+
- drivers/general/queries/NtstatusExplicitCast3/NtstatusExplicitCast3.ql
37+
- drivers/general/queries/NullCharacterPointerAssignment/NullCharacterPointerAssignment.ql
38+
- drivers/general/queries/OperandAssignment/OperandAssignment.ql
39+
- drivers/general/queries/PointerVariableSize/PointerVariableSize.ql
40+
- drivers/general/queries/PoolTagIntegral/PoolTagIntegral.ql
41+
- drivers/general/queries/RoleTypeCorrectlyUsed/RoleTypeCorrectlyUsed.ql
42+
- drivers/general/queries/RoutineFunctionTypeNotExpected/RoutineFunctionTypeNotExpected.ql
43+
- drivers/general/queries/StrSafe/StrSafe.ql
44+
- drivers/general/queries/StrictTypeMatch/StrictTypeMatch.ql
45+
- drivers/wdm/queries/IllegalFieldAccess/IllegalFieldAccess.ql
46+
- drivers/wdm/queries/IllegalFieldAccess2/IllegalFieldAccess2.ql
47+
- drivers/wdm/queries/IllegalFieldWrite/IllegalFieldWrite.ql
48+
- drivers/wdm/queries/InitNotCleared/InitNotCleared.ql
49+
- drivers/wdm/queries/KeWaitLocal/KeWaitLocal.ql
50+
- drivers/wdm/queries/MultiplePagedCode/MultiplePagedCode.ql
51+
- drivers/wdm/queries/ObReferenceMode/ObReferenceMode.ql
52+
- drivers/wdm/queries/OpaqueMdlUse/OpaqueMdlUse.ql
53+
- drivers/wdm/queries/OpaqueMdlWrite/OpaqueMdlWrite.ql
54+
- drivers/wdm/queries/PendingStatusError/PendingStatusError.ql
55+
- drivers/wdm/queries/WrongDispatchTableAssignment/WrongDispatchTableAssignment.ql
56+
- microsoft/Likely Bugs/Boundary Violations/PaddingByteInformationDisclosure.ql
57+
- microsoft/Likely Bugs/Conversion/BadOverflowGuard.ql
58+
- microsoft/Likely Bugs/Conversion/InfiniteLoop.ql
59+
- microsoft/Likely Bugs/Memory Management/UseAfterFree/UseAfterFree.ql
60+
- microsoft/Likely Bugs/UninitializedPtrField.ql
61+
- microsoft/Security/Crytpography/HardcodedIVCNG.ql
62+
- queries: .
63+
from: microsoft/cpp-queries
64+
version: 0.0.2
65+
- include:
66+
query path:
67+
- Best Practices/Likely Errors/OffsetUseBeforeRangeCheck.ql
68+
- Likely Bugs/Arithmetic/IntMultToLong.ql
69+
- Likely Bugs/Arithmetic/SignedOverflowCheck.ql
70+
- Likely Bugs/Conversion/CastArrayPointerArithmetic.ql
71+
- Likely Bugs/Likely Typos/IncorrectNotOperatorUsage.ql
72+
- Likely Bugs/Memory Management/SuspiciousSizeof.ql
73+
- Likely Bugs/Memory Management/UninitializedLocal.ql
74+
- Security/CWE/CWE-121/UnterminatedVarargsCall.ql
75+
- Security/CWE/CWE-457/ConditionallyUninitializedVariable.ql
76+
- Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql
77+
- Security/CWE/CWE-468/IncorrectPointerScaling.ql
78+
- Security/CWE/CWE-468/IncorrectPointerScalingVoid.ql
79+
- Security/CWE/CWE-676/PotentiallyDangerousFunction.ql
80+
- Security/CWE/CWE-119/OverflowBuffer.ql

0 commit comments

Comments
 (0)