Merge pull request #49 from meshcloud/feature/azure-budget-alert-polishing

feat: Azure budget alert for subscriptions

Author: ishabakeh

azure/terraform/monitoring/budget-alert-subscription/main.tf

@@ -1,4 +1,11 @@
-
+locals {
+  start_date                           = formatdate("YYYY-MM-01'T'hh:mm:ssZ", timestamp())
+  end_date                             = formatdate("2026-MM-01'T'hh:mm:ssZ", local.start_date)
+  location                             = "germanywestcentral"
+  action_group_name                    = "budget_action_group"
+  action_group_short_name              = "bdgt_ag"
+  resource_group_for_action_group_name = "rg-${local.action_group_name}"
+}
 //-----------------------------------------------
 // Budget on subscription level
 //-----------------------------------------------
@@ -10,43 +17,29 @@ resource "azurerm_consumption_budget_subscription" "subscription_budget" {
   name            = var.budget_name
   subscription_id = data.azurerm_subscription.subscription.id
 
-  amount     = 1000
+  amount     = var.monthly_budget_amount
   time_grain = "Monthly"
 
   time_period {
-    start_date = var.start_date #"2022-06-01T00:00:00Z"
-    end_date   = var.end_date   #"2022-07-01T00:00:00Z"
+    start_date = local.start_date #"2022-06-01T00:00:00Z"
+    end_date   = local.end_date   #"2022-07-01T00:00:00Z"
   }
 
-  # filter {
-  #   dimension {
-  #     name = "ResourceGroupName"
-  #     values = [
-  #       azurerm_resource_group.example.name,
-  #     ]
-  #   }
-
-  #   tag {
-  #     name = "foo"
-  #     values = [
-  #       "bar",
-  #       "baz",
-  #     ]
-  #   }
-  # }
-
   notification {
     enabled   = true
-    threshold = 90.0
+    threshold = var.actual_threshold
     operator  = "EqualTo"
 
     contact_emails = var.contact_emails
 
+    contact_groups = [
+      azurerm_monitor_action_group.action_group.id,
+    ]
   }
 
   notification {
-    enabled        = false
-    threshold      = 100.0
+    enabled        = true
+    threshold      = var.forcasted_threshold
     operator       = "GreaterThan"
     threshold_type = "Forecasted"
 
@@ -63,11 +56,18 @@ resource "azurerm_consumption_budget_subscription" "subscription_budget" {
 // Action Group
 //-----------------------------------------------
 resource "azurerm_resource_group" "rg_action_group" {
-  name     = var.resource_group_for_action_group_name
-  location = var.location
+  name     = local.resource_group_for_action_group_name
+  location = local.location
 }
 resource "azurerm_monitor_action_group" "action_group" {
-  name                = "budget_action_group"
+  name                = local.action_group_name
   resource_group_name = azurerm_resource_group.rg_action_group.name
-  short_name          = "bdgt_ag"
+  short_name          = local.action_group_short_name
+
+
+  webhook_receiver {
+    name                    = "callmyapiaswell"
+    service_uri             = "http://example.com/alert"
+    use_common_alert_schema = true
+  }
 }

azure/terraform/monitoring/budget-alert-subscription/outputs.tf

@@ -1,3 +1,7 @@
 output "Budget_notification" {
   value = azurerm_consumption_budget_subscription.subscription_budget.notification
 }
+
+output "start_date" {
+  value = azurerm_consumption_budget_subscription.subscription_budget.time_period[0].start_date
+}

azure/terraform/monitoring/budget-alert-subscription/variables.tf

@@ -1,45 +1,52 @@
-
-variable "location" {
-  type    = string
-  default = "westeurope"
-}
-
 variable "budget_name" {
-  type    = string
-  default = "budget_alert"
+  type        = string
+  description = "Name of the budget alert rule"
+  default     = "budget_alert"
 }
 
 variable "subscription_id" {
   type        = string
   description = "The ID of the subscription at which you want to assign the budget"
 }
 
-variable "resource_group_for_action_group_name" {
-  type        = string
-  description = "The name of the resource group to deploy the action group inside"
-  default     = "rg_action_group"
+variable "contact_emails" {
+  type        = list(string)
+  description = "List of emails of the users who should receive the Budget alert. e.g. ['foo@example.com', 'bar@example.com']"
 }
 
-variable "end_date" {
-  type        = string
-  description = "End date of the budget rule, Timestamp in the format YYYY-MM-DDTHH:MM:SSZ"
-  validation {
-    condition     = can(regex("^\\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T\\d{2}:\\d{2}:\\d{2}Z$", var.end_date))
-    error_message = "Timestamp must be in the format YYYY-MM-DDTHH:MM:SSZ"
-  }
+variable "monthly_budget_amount" {
+  type        = number
+  description = "Set the monthly budget goal for this subscription"
+  default     = 100
 }
 
-variable "start_date" {
+variable "actual_threshold" {
   type        = string
-  description = "Start date of the budget rule, should be first day of the month"
-  validation {
-    condition     = can(regex("^\\d{4}-(0[1-9]|1[0-2])-(01)T\\d{2}:\\d{2}:\\d{2}Z$", var.start_date))
-    error_message = "The 'start_date' must be in the format 'YYYY-MM-01THH:MM:SSZ', e.g., '2023-11-01T00:00:00Z'."
-  }
+  description = "The precise percentage of the monthly budget at which you wish to activate the alert upon reaching. E.g. '15' for 15% or '120' for 120%"
 }
 
-variable "contact_emails" {
-  type        = list(string)
-  description = "List of emails of the users who should receive the Budget alert. e.g. ['foo@example.com', 'bar@example.com']"
+variable "forcasted_threshold" {
+  type        = string
+  description = "The forcasted percentage of the monthly budget at which you wish to activate the alert upon reaching. E.g. '15' for 15% or '120' for 120%"
 }
 
+
+// Uncomment next 2 variables if you want to change the start and end date via inputs --------------------------------
+# variable "end_date" {
+#   type        = string
+#   description = "End date of the budget rule, Timestamp in the format YYYY-MM-DDTHH:MM:SSZ"
+#   validation {
+#     condition     = can(regex("^\\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T\\d{2}:\\d{2}:\\d{2}Z$", var.end_date))
+#     error_message = "Timestamp must be in the format YYYY-MM-DDTHH:MM:SSZ"
+#   }
+# }
+
+# variable "start_date" {
+#   type        = string
+#   description = "Start date of the budget rule, should be first day of the month. Timestamp in the format YYYY-MM-DDTHH:MM:SSZ"
+#   validation {
+#     condition     = can(regex("^\\d{4}-(0[1-9]|1[0-2])-(01)T\\d{2}:\\d{2}:\\d{2}Z$", var.start_date))
+#     error_message = "The 'start_date' must be in the format 'YYYY-MM-01THH:MM:SSZ', e.g., '2023-11-01T00:00:00Z'."
+#   }
+# }
+//------------------------------------------------------------------------------------------------------------------------