Fix PM seed refresh tracking

Author: merefield

lib/termcourse/ui.rb

@@ -2352,12 +2352,13 @@ def maybe_refresh_pm_unread_count(now: Time.now)
 
     def refresh_notification_unread_count
       data = with_errors { @client.notification_totals }
-      return false unless data.is_a?(Hash)
+      return { notification: false, pm: false } unless data.is_a?(Hash)
 
       count = data["unread_notifications"].to_i
       @notification_unread_count = [count, 0].max
       @live_updates&.set_unread_notification_count(@notification_unread_count)
 
+      pm_refreshed = false
       pm_count =
         if data.key?("unread_personal_messages")
           data["unread_personal_messages"].to_i
@@ -2367,8 +2368,9 @@ def refresh_notification_unread_count
       unless pm_count.nil?
         @pm_unread_count = [pm_count, 0].max
         @live_updates&.set_pm_unread_count(@pm_unread_count)
+        pm_refreshed = true
       end
-      true
+      { notification: true, pm: pm_refreshed }
     end
 
     def maybe_refresh_notification_unread_count(now: Time.now)
@@ -2379,7 +2381,7 @@ def maybe_refresh_notification_unread_count(now: Time.now)
       return if @last_notification_unread_refresh_at && (now - @last_notification_unread_refresh_at) < @notification_unread_refresh_interval
 
       refreshed = refresh_notification_unread_count
-      @last_notification_unread_refresh_at = now if refreshed
+      @last_notification_unread_refresh_at = now if refreshed[:notification]
     end
 
     def maybe_refresh_status_counts(now: Time.now)
@@ -2415,8 +2417,8 @@ def consume_topic_list_refresh_request(filter:, top_period:)
 
     def seed_status_counts_from_server(now: Time.now)
       notification_refreshed = refresh_notification_unread_count
-      pm_refreshed = @pm_unread_count.to_i > 0 ? true : refresh_pm_unread_count
-      @last_notification_unread_refresh_at = now if notification_refreshed
+      pm_refreshed = notification_refreshed[:pm] || refresh_pm_unread_count
+      @last_notification_unread_refresh_at = now if notification_refreshed[:notification]
       @last_pm_unread_refresh_at = now if pm_refreshed
     end
 

test/ui_caching_test.rb

@@ -292,6 +292,24 @@ def test_maybe_refresh_status_counts_resyncs_once_after_live_reconnect
       assert_equal 2, @ui.instance_variable_get(:@pm_unread_count)
     end
 
+    def test_seed_status_counts_from_server_refreshes_pm_when_notification_refresh_did_not_seed_pm
+      @ui.instance_variable_set(:@pm_unread_count, 3)
+      @ui.define_singleton_method(:refresh_notification_unread_count) { { notification: false, pm: false } }
+
+      pm_refreshed = false
+      @ui.define_singleton_method(:refresh_pm_unread_count) do
+        pm_refreshed = true
+        true
+      end
+
+      now = Time.utc(2026, 3, 15, 12, 0, 0)
+      @ui.send(:seed_status_counts_from_server, now: now)
+
+      assert_equal true, pm_refreshed
+      assert_nil @ui.instance_variable_get(:@last_notification_unread_refresh_at)
+      assert_equal now, @ui.instance_variable_get(:@last_pm_unread_refresh_at)
+    end
+
     def test_mark_notification_read_decrements_local_and_live_unread_counts
       live_updates = FakeLiveUpdates.new(4, [], 0)
       notification = { "id" => 99, "read" => false }

test/ui_renderer_test.rb

@@ -501,10 +501,11 @@ def test_refresh_notification_unread_count_preserves_existing_count_on_failed_re
       @ui.instance_variable_set(:@notification_unread_count, 6)
       @ui.define_singleton_method(:with_errors) { nil }
 
-      @ui.send(:refresh_notification_unread_count)
+      result = @ui.send(:refresh_notification_unread_count)
 
       assert_equal 6, @ui.instance_variable_get(:@notification_unread_count)
       assert_equal 6, live_updates.unread_notification_count
+      assert_equal false, result[:notification]
     end
 
     def test_unread_notification_count_uses_live_zero_value