go1.18.10 Error

[Nucito]

Example used:
androidlib.zip

{"error": "Failed to parse file: no valid pclntab found"}

[stevemk14ebr]

The moduledata parsing is finding the right moduledata but failing to verify it is the correct shape. Not sure why ATM. objfile.go ModuleDataTable function

[stevemk14ebr]

the issue seems to be we parse the raw disk file not the relocated memory view after loading. For your file the raw addresses don't seem valid prior to relocation.

[stevemk14ebr]

this is kind of unfortunate, the upstream go runtime code doesn't support the type of relocations this binary has. We make an assumption that virtual addresses are valid and can be read directly by mapping the VA in the binary to the file addresses. In your binary the VAs in the binary are not valid, they only become valid after relocation. We cannot extend the code to do relocations without supporting the more complex relocation types this binary has, for all architectures, for all executable formats (pe, elf, macho). That's quite a bit of work, this is the first binary i've had this issue with, so hopefully it is not common. A proper fix would at minimum involve extending the upstream runtime code to handle more relocation types, and then adjusting the file reading logic to relocate first and then read. This is not trivial to massage in now, and would be a significant divergence from upstream. For now I don't think we should do this, a future version of the tool (not based on the go runtime upstream) would be the proper way to handle this 😢

Thank you for submitting this, it is an interesting case

[stevemk14ebr]

#95 similar I think