From the prop-design (component-manifesto) audit. DropdownItem is the worst offender for slot naming and configuration soup, and it's heavily composed (Table editable cells, Breadcrumb menu, etc.), so this needs a design call rather than a unilateral rename.
Two problems:
- Inconsistent leading/trailing naming vs the rest of the library. DropdownItem has
icon (leading) + leading, and value + trailing + endIcon (trailing); DropdownSubTrigger has icon/trailing; DropdownLabel has action. Button/Input use leadingIcon/trailingIcon. Standardize on leadingIcon/trailingIcon where it's an icon slot.
- Trailing slot soup. DropdownItem carries three coexisting trailing slots (
value text, trailing rich content, endIcon icon) that render in a fixed order and overlap in meaning. Per the manifesto ("compose primitives, don't turn components into control panels"), collapse these toward composition (a single trailing slot the caller composes, or trailing subcomponents).
Because DropdownItem is composed across several components and in-flight branches (#15, #6, #53), coordinate the rename so it doesn't break those.
From the prop-design (component-manifesto) audit. DropdownItem is the worst offender for slot naming and configuration soup, and it's heavily composed (Table editable cells, Breadcrumb menu, etc.), so this needs a design call rather than a unilateral rename.
Two problems:
icon(leading) +leading, andvalue+trailing+endIcon(trailing); DropdownSubTrigger hasicon/trailing; DropdownLabel hasaction. Button/Input useleadingIcon/trailingIcon. Standardize onleadingIcon/trailingIconwhere it's an icon slot.valuetext,trailingrich content,endIconicon) that render in a fixed order and overlap in meaning. Per the manifesto ("compose primitives, don't turn components into control panels"), collapse these toward composition (a single trailing slot the caller composes, or trailing subcomponents).Because DropdownItem is composed across several components and in-flight branches (#15, #6, #53), coordinate the rename so it doesn't break those.