Merge pull request #8 from magicaleks/SigV2-impl

fix: recvWindow + sig review

Author: magicaleks

client.go

@@ -140,11 +140,17 @@ func (c *Client) parseRequest(r *request, opts ...RequestOption) (err error) {
 		return err
 	}
 
-	r.setParam(recvWindowKey, r.recvWindow)
+	recvWindow := r.recvWindow
+	if recvWindow == 0 {
+		recvWindow = 10000
+	}
+
+	r.setParam(recvWindowKey, recvWindow)
 
 	timestamp := time.Now().UnixNano() / 1e6
 	if r.query != nil {
 		r.setParam(timestampKey, timestamp)
+		c.debug(r.query.Encode())
 		sign := computeHmac256(r.query.Encode(), c.SecretKey)
 		r.setParam(signatureKey, sign)
 	} else {
@@ -197,7 +203,8 @@ func (c *Client) callAPI(ctx context.Context, r *request, opts ...RequestOption)
 	}
 	req = req.WithContext(ctx)
 	req.Header = r.header
-	c.debug("request: %#v", req)
+	// c.debug("request: %#v", req)
+	c.debug("request url: %#v", req.URL.String())
 	f := c.do
 	if f == nil {
 		f = c.HTTPClient.Do
@@ -216,7 +223,7 @@ func (c *Client) callAPI(ctx context.Context, r *request, opts ...RequestOption)
 			err = cerr
 		}
 	}()
-	c.debug("response: %#v", res)
+	// c.debug("response: %#v", res)
 	c.debug("response body: %s", string(data))
 	c.debug("response status code: %d", res.StatusCode)
 

order_service.go

@@ -288,37 +288,35 @@ func (s *GetOrderService) Do(ctx context.Context, opts ...RequestOption) (res *G
 }
 
 type GetOpenOrdersService struct {
-	c             *Client
-	symbol        string
-	orderId       int
-	clientOrderID string
+	c      *Client
+	symbol string
 }
 
 // Define response of get order request
 type GetOpenOrdersResponse struct {
-	Orders []*OpenOrderResponse `json:"orders"`
+	Orders []*GetOrderResponse `json:"orders"`
 }
 
-type OpenOrderResponse struct {
-	Symbol        string           `json:"symbol"`
-	OrderId       int              `json:"orderId"`
-	Side          SideType         `json:"side"`
-	PositionSide  PositionSideType `json:"positionSide"`
-	OrderType     OrderType        `json:"type"`
-	OrigQuantity  string           `json:"origQty"`
-	Price         string           `json:"price"`
-	Quantity      string           `json:"executedQty"`
-	AveragePrice  string           `json:"avgPrice"`
-	CumQuote      string           `json:"cumQuote"`
-	StopPrice     string           `json:"stopPrice"`
-	Profit        string           `json:"profit"`
-	Fee           string           `json:"commission"`
-	Status        OrderStatus      `json:"status"`
-	Time          int64            `json:"time"`
-	UpdateTime    int64            `json:"ppdateTime"`
-	WorkingType   OrderWorkingType `json:"workingType"`
-	ClientOrderID string           `json:"clientOrderID"`
-}
+// type OpenOrderResponse struct {
+// 	Symbol        string           `json:"symbol"`
+// 	OrderId       int              `json:"orderId"`
+// 	Side          SideType         `json:"side"`
+// 	PositionSide  PositionSideType `json:"positionSide"`
+// 	OrderType     OrderType        `json:"type"`
+// 	OrigQuantity  string           `json:"origQty"`
+// 	Price         string           `json:"price"`
+// 	Quantity      string           `json:"executedQty"`
+// 	AveragePrice  string           `json:"avgPrice"`
+// 	CumQuote      string           `json:"cumQuote"`
+// 	StopPrice     string           `json:"stopPrice"`
+// 	Profit        string           `json:"profit"`
+// 	Fee           string           `json:"commission"`
+// 	Status        OrderStatus      `json:"status"`
+// 	Time          int64            `json:"time"`
+// 	UpdateTime    int64            `json:"ppdateTime"`
+// 	WorkingType   OrderWorkingType `json:"workingType"`
+// 	ClientOrderID string           `json:"clientOrderID"`
+// }
 
 func (s *GetOpenOrdersService) Symbol(symbol string) *GetOpenOrdersService {
 	s.symbol = symbol