Skip to content

Commit 1ed2968

Browse files
committed
Fix: PHP 8.1 compatibility fix for SSE emitter test
1 parent a9089a2 commit 1ed2968

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/conformance.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,5 @@ jobs:
7070
mode: client
7171
command: 'php conformance/everything-client.php'
7272
suite: all
73-
expected-failures: ./conformance/conformance-baseline.yml
73+
timeout: 120000
74+
expected-failures: ./conformance/conformance-baseline.yml

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ This file was introduced during the v1.7.x series. Structured entries below cove
2525
labels, testing) and `conformance/README.md`.
2626
- GitHub action for official MCP conformance tests
2727
- GitHub action for unit tests and PHPStan
28+
- PHP 8.1 compatibility fix for SSE emitter test
2829

2930
### Removed
3031

tests/Server/Transport/Http/Sse/SseEmitterTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ function (string $s) use (&$buffer): void {
7878
public function testHasEmittedStartsFalse(): void
7979
{
8080
$emitter = new SseEmitter(
81-
static fn (string $s): null => null,
81+
static function (string $s): void {
82+
},
8283
static fn (): bool => false,
8384
);
8485
$this->assertFalse($emitter->hasEmitted());

0 commit comments

Comments
 (0)