Regression on ROS 2 Buildfarm for Rolling

[Yadunund]

fuse 1.2.1 is failing to build for Rolling on the ROS 2 build farm likely due to API changes in rclcpp. This is blocking the announced Rolling sync. We will proceed with the sync which will remove these binaries from Rolling but they will be added once the build is fixed and a new release is bloomed.

MT CMakeFiles/fuse_core.dir/src/async_motion_model.cpp.o -MF CMakeFiles/fuse_core.dir/src/async_motion_model.cpp.o.d -o CMakeFiles/fuse_core.dir/src/async_motion_model.cpp.o -c /tmp/binarydeb/ros-rolling-fuse-core-1.2.1/src/async_motion_model.cpp
In file included from /usr/include/c++/13/bits/alloc_traits.h:33,
                 from /usr/include/c++/13/ext/alloc_traits.h:34,
                 from /usr/include/c++/13/bits/hashtable_policy.h:39,
                 from /usr/include/c++/13/bits/hashtable.h:35,
                 from /usr/include/c++/13/bits/unordered_map.h:33,
                 from /usr/include/c++/13/unordered_map:41,
                 from /usr/include/c++/13/functional:63,
                 from /tmp/binarydeb/ros-rolling-fuse-core-1.2.1/src/async_motion_model.cpp:34:
/usr/include/c++/13/bits/stl_construct.h: In instantiation of ‘void std::_Construct(_Tp*, _Args&& ...) [with _Tp = fuse_core::CallbackAdapter; _Args = {shared_ptr<rclcpp::Context>&}]’:
/usr/include/c++/13/bits/alloc_traits.h:661:19:   required from ‘static void std::allocator_traits<std::allocator<void> >::construct(allocator_type&, _Up*, _Args&& ...) [with _Up = fuse_core::CallbackAdapter; _Args = {std::shared_ptr<rclcpp::Context>&}; allocator_type = std::allocator<void>]’
/usr/include/c++/13/bits/shared_ptr_base.h:604:39:   required from ‘std::_Sp_counted_ptr_inplace<_Tp, _Alloc, _Lp>::_Sp_counted_ptr_inplace(_Alloc, _Args&& ...) [with _Args = {std::shared_ptr<rclcpp::Context>&}; _Tp = fuse_core::CallbackAdapter; _Alloc = std::allocator<void>; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/13/bits/shared_ptr_base.h:971:16:   required from ‘std::__shared_count<_Lp>::__shared_count(_Tp*&, std::_Sp_alloc_shared_tag<_Alloc>, _Args&& ...) [with _Tp = fuse_core::CallbackAdapter; _Alloc = std::allocator<void>; _Args = {std::shared_ptr<rclcpp::Context>&}; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/13/bits/shared_ptr_base.h:1712:14:   required from ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator<void>; _Args = {std::shared_ptr<rclcpp::Context>&}; _Tp = fuse_core::CallbackAdapter; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/13/bits/shared_ptr.h:464:59:   required from ‘std::shared_ptr<_Tp>::shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator<void>; _Args = {std::shared_ptr<rclcpp::Context>&}; _Tp = fuse_core::CallbackAdapter]’
/usr/include/c++/13/bits/shared_ptr.h:1009:14:   required from ‘std::shared_ptr<typename std::enable_if<(! std::is_array< <template-parameter-1-1> >::value), _Tp>::type> std::make_shared(_Args&& ...) [with _Tp = fuse_core::CallbackAdapter; _Args = {shared_ptr<rclcpp::Context>&}; typename enable_if<(! is_array< <template-parameter-1-1> >::value), _Tp>::type = fuse_core::CallbackAdapter]’
/tmp/binarydeb/ros-rolling-fuse-core-1.2.1/src/async_motion_model.cpp:101:54:   required from here
/usr/include/c++/13/bits/stl_construct.h:119:7: error: invalid new-expression of abstract class type ‘fuse_core::CallbackAdapter’
  119 |       ::new((void*)__p) _Tp(std::forward<_Args>(__args)...);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/binarydeb/ros-rolling-fuse-core-1.2.1/include/fuse_core/async_motion_model.hpp:40,
                 from /tmp/binarydeb/ros-rolling-fuse-core-1.2.1/src/async_motion_model.cpp:39:
/tmp/binarydeb/ros-rolling-fuse-core-1.2.1/include/fuse_core/callback_wrapper.hpp:155:7: note:   because the following virtual functions are pure within ‘fuse_core::CallbackAdapter’:
  155 | class CallbackAdapter : public rclcpp::Waitable
      |       ^~~~~~~~~~~~~~~
In file included from /opt/ros/rolling/include/rclcpp/rclcpp/executors/executor_notify_waitable.hpp:25,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/executor.hpp:32,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/executors.hpp:21,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/rclcpp.hpp:172,
                 from /tmp/binarydeb/ros-rolling-fuse-core-1.2.1/include/fuse_core/callback_wrapper.hpp:43:
/opt/ros/rolling/include/rclcpp/rclcpp/waitable.hpp:273:3: note:     ‘virtual std::vector<std::shared_ptr<rclcpp::TimerBase> > rclcpp::Waitable::get_timers() const’
  273 |   get_timers() const = 0;

Detailed logs: https://build.ros2.org/view/Rbin_uN64/job/Rbin_uN64__fuse_core__ubuntu_noble_amd64__binary/166/consoleFull

[KB1110]

I have added a pull request -> #398 to resolve this issue. Let me know if any changes are to be done