Skip to content

Commit 5708d84

Browse files
committed
fix: apply MPI DependsOn feature on the latest commit change
Signed-off-by: Amir380-A <62997533+Amir380-A@users.noreply.github.com>
1 parent 70c55c4 commit 5708d84

2 files changed

Lines changed: 29 additions & 36 deletions

File tree

charts/kubeflow-trainer/files/runtimes/deepspeed-distributed.yaml

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
1514
apiVersion: trainer.kubeflow.org/v1alpha1
1615
kind: ClusterTrainingRuntime
1716
metadata:
@@ -39,6 +38,19 @@ spec:
3938
targetReplicatedJobs:
4039
- launcher
4140
replicatedJobs:
41+
- name: launcher
42+
template:
43+
metadata:
44+
labels:
45+
trainer.kubeflow.org/trainjob-ancestor-step: trainer
46+
spec:
47+
template:
48+
spec:
49+
containers:
50+
- name: node
51+
image: {{ include "trainer.runtimeImage" (list .Values.runtimes.deepspeedDistributed.image .) }}
52+
securityContext:
53+
runAsUser: 1000
4254
- name: node
4355
template:
4456
spec:
@@ -59,20 +71,3 @@ spec:
5971
tcpSocket:
6072
port: 2222
6173
initialDelaySeconds: 5
62-
63-
- name: launcher
64-
dependsOn:
65-
- name: node
66-
status: Ready
67-
template:
68-
metadata:
69-
labels:
70-
trainer.kubeflow.org/trainjob-ancestor-step: trainer
71-
spec:
72-
template:
73-
spec:
74-
containers:
75-
- name: node
76-
image: {{ include "trainer.runtimeImage" (list .Values.runtimes.deepspeedDistributed.image .) }}
77-
securityContext:
78-
runAsUser: 1000

charts/kubeflow-trainer/files/runtimes/mlx-distributed.yaml

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
1514
apiVersion: trainer.kubeflow.org/v1alpha1
1615
kind: ClusterTrainingRuntime
1716
metadata:
@@ -39,6 +38,22 @@ spec:
3938
targetReplicatedJobs:
4039
- launcher
4140
replicatedJobs:
41+
- name: launcher
42+
dependsOn:
43+
- name: node
44+
status: Ready
45+
template:
46+
metadata:
47+
labels:
48+
trainer.kubeflow.org/trainjob-ancestor-step: trainer
49+
spec:
50+
template:
51+
spec:
52+
containers:
53+
- name: node
54+
image: {{ include "trainer.runtimeImage" (list .Values.runtimes.mlxDistributed.image .) }}
55+
securityContext:
56+
runAsUser: 1000
4257
- name: node
4358
template:
4459
spec:
@@ -59,20 +74,3 @@ spec:
5974
tcpSocket:
6075
port: 2222
6176
initialDelaySeconds: 5
62-
63-
- name: launcher
64-
dependsOn:
65-
- name: node
66-
status: Ready
67-
template:
68-
metadata:
69-
labels:
70-
trainer.kubeflow.org/trainjob-ancestor-step: trainer
71-
spec:
72-
template:
73-
spec:
74-
containers:
75-
- name: node
76-
image: {{ include "trainer.runtimeImage" (list .Values.runtimes.mlxDistributed.image .) }}
77-
securityContext:
78-
runAsUser: 1000

0 commit comments

Comments
 (0)