fix: disable parquet dictionary filter by default (bytedance#40)

Author: guhaiyan0221

bolt/connectors/hive/HiveConfig.cpp

@@ -303,8 +303,14 @@ uint8_t HiveConfig::arrowBridgeTimestampUnit(
   return session->get<uint8_t>(kArrowBridgeTimestampUnit, 9 /* nano */);
 }
 
+// The ParquetDictionaryFilter reads DictionaryPage during query
+// execution, which leads to read amplification in TPC-DS benchmark scenarios.
+// It is disabled by default, and is only recommended to be enabled manually
+// when the dictionary can provide a high filtering rate (i.e., the filter can
+// significantly reduce the amount of data that needs to be processed
+// subsequently)
 bool HiveConfig::isDictionaryFilterEnabled() const {
-  return config_->get<bool>(kParquetDictionaryFilterEnabled, true);
+  return config_->get<bool>(kParquetDictionaryFilterEnabled, false);
 }
 
 int32_t HiveConfig::decodeRepDefPageCount() const {

bolt/dwio/common/Options.h

@@ -161,7 +161,7 @@ class RowReaderOptions {
   /// dictionaries
   /// against query filters. This can significantly improve performance for
   /// selective queries. Defaults to true.
-  bool enableDictionaryFilter_ = true;
+  bool enableDictionaryFilter_ = false;
 
   int32_t decodeRepDefPageCount_{10};
   int32_t parquetRepDefMemoryLimit_{16UL << 20};

bolt/dwio/parquet/tests/reader/ParquetDictionaryFilterTest.cpp

@@ -99,6 +99,7 @@ class DictionaryFilterTest : public ParquetTestBase {
     auto reader =
         createReader(filePath_, dwio::common::ReaderOptions{leafPool_.get()});
     dwio::common::RowReaderOptions rowReaderOpts;
+    rowReaderOpts.setEnableDictionaryFilter(true);
     rowReaderOpts.setScanSpec(parentSpec);
 
     auto rowReader = reader->createRowReader(rowReaderOpts);
@@ -324,6 +325,7 @@ TEST_F(DictionaryFilterTest, TestMultiColumnFilter) {
   int16sSpec->setFilter(common::createBigintValues({0}, true));
 
   dwio::common::RowReaderOptions rowReaderOpts;
+  rowReaderOpts.setEnableDictionaryFilter(true);
   rowReaderOpts.setScanSpec(parentSpec);
 
   auto rowReader = reader->createRowReader(rowReaderOpts);
@@ -512,6 +514,7 @@ TEST_F(DictionaryFilterTest, TestMultiValueDictionaryFilter) {
   parentSpec->addField("strings", stringChannel);
 
   dwio::common::RowReaderOptions rowReaderOpts;
+  rowReaderOpts.setEnableDictionaryFilter(true);
   rowReaderOpts.setScanSpec(parentSpec);
   auto rowReader = reader->createRowReader(rowReaderOpts);
 
@@ -555,13 +558,13 @@ TEST_F(DictionaryFilterTest, TestMultiValueDictionaryFilter) {
 }
 
 TEST_F(DictionaryFilterTest, RowReaderOptionDefaultValues) {
-  // Test that dictionary filtering is enabled by default
+  // Test that dictionary filtering is disabled by default
   dwio::common::RowReaderOptions options;
-  EXPECT_TRUE(options.isDictionaryFilterEnabled());
+  EXPECT_FALSE(options.isDictionaryFilterEnabled());
 
   // Test disabling dictionary filtering
-  options.setEnableDictionaryFilter(false);
-  EXPECT_FALSE(options.isDictionaryFilterEnabled());
+  options.setEnableDictionaryFilter(true);
+  EXPECT_TRUE(options.isDictionaryFilterEnabled());
 }
 
 TEST_F(DictionaryFilterTest, NonMatchingFilterWithDictionaryFilteringEnabled) {