fix silent error handling of all parsers failed to stream

Author: keshon

internal/command/music/common/status_listener.go

@@ -88,6 +88,14 @@ func ListenPlayerStatusSlash(session *discordgo.Session, event *discordgo.Intera
 						appLog.Warn().Str("status", "added").Str("guild_id", guildID).Err(err).Msg("guild_status_update_failed")
 					}
 					return
+
+				case player.StatusError:
+					_ = discordreply.FollowupEmbedEphemeral(session, event, &discordgo.MessageEmbed{
+						Title:       statusEmoji(player.StatusError) + " Playback Error",
+						Description: "Could not start or continue playback (for example all stream parsers failed).",
+						Color:       discordreply.EmbedColor,
+					})
+					return
 				}
 			}
 		}

internal/command/music/next/next.go

@@ -1,6 +1,7 @@
 package next
 
 import (
+	"errors"
 	"fmt"
 
 	"github.com/bwmarrin/discordgo"
@@ -9,6 +10,7 @@ import (
 	"github.com/keshon/melodix/internal/discord"
 	"github.com/keshon/melodix/internal/discord/discordreply"
 	"github.com/keshon/melodix/internal/discord/perm"
+	musicplayer "github.com/keshon/melodix/pkg/music/player"
 )
 
 type Next struct {
@@ -76,6 +78,10 @@ func (c *Next) Run(ctx interface{}) error {
 
 	player.Stop(false)
 	if err = player.PlayNext(voiceState.ChannelID); err != nil {
+		if errors.Is(err, musicplayer.ErrTrackStartFailed) {
+			common.ListenPlayerStatusSlash(s, e, player, c.Bot, guildID, slashCtx.AppLog)
+			return nil
+		}
 		discordreply.FollowupEmbedEphemeral(s, e, &discordgo.MessageEmbed{
 			Title:       "🎵 Playback Error",
 			Description: fmt.Sprintf("Failed to play next track.\n\n**Error:** %v", err),
@@ -86,4 +92,3 @@ func (c *Next) Run(ctx interface{}) error {
 	common.ListenPlayerStatusSlash(s, e, player, c.Bot, guildID, slashCtx.AppLog)
 	return nil
 }
-

internal/command/music/play/play.go

@@ -11,6 +11,7 @@ import (
 	"github.com/keshon/melodix/internal/discord/discordreply"
 	"github.com/keshon/melodix/internal/discord/perm"
 	"github.com/keshon/melodix/internal/storage"
+	"github.com/keshon/melodix/pkg/music/player"
 )
 
 type Play struct {
@@ -212,10 +213,28 @@ func (c *Play) Run(ctx interface{}) error {
 	}
 
 	if !p.IsPlaying() {
-		_ = p.PlayNext(voiceState.ChannelID)
+		if err := p.PlayNext(voiceState.ChannelID); err != nil {
+			if errors.Is(err, player.ErrTrackStartFailed) {
+				common.ListenPlayerStatusSlash(s, e, p, c.Bot, guildID, slashCtx.AppLog)
+				return nil
+			}
+			if errors.Is(err, player.ErrNoTracksInQueue) {
+				discordreply.FollowupEmbedEphemeral(s, e, &discordgo.MessageEmbed{
+					Title:       "🎵 Queue",
+					Description: "Nothing is in the queue to play.",
+					Color:       discordreply.EmbedColor,
+				})
+				return nil
+			}
+			discordreply.FollowupEmbedEphemeral(s, e, &discordgo.MessageEmbed{
+				Title:       "🎵 Playback Error",
+				Description: fmt.Sprintf("%v", err),
+				Color:       discordreply.EmbedColor,
+			})
+			return nil
+		}
 	}
 
 	common.ListenPlayerStatusSlash(s, e, p, c.Bot, guildID, slashCtx.AppLog)
 	return nil
 }
-

pkg/music/player/player.go

@@ -27,8 +27,11 @@ const (
 )
 
 var (
-	ErrNoTrackPlaying     = errors.New("no track is currently playing")
-	ErrNoTracksInQueue    = errors.New("no tracks in queue")
+	ErrNoTrackPlaying  = errors.New("no track is currently playing")
+	ErrNoTracksInQueue = errors.New("no tracks in queue")
+	// ErrTrackStartFailed is returned when a dequeued track could not start playback (e.g. all parsers failed)
+	// and there are no further tracks in the queue.
+	ErrTrackStartFailed   = errors.New("track failed to start")
 	ErrNoParsersForTrack  = errors.New("track has no available parsers")
 	ErrPauseNotSupported  = errors.New("pause is not supported")
 	ErrResumeNotSupported = errors.New("resume is not supported")
@@ -241,6 +244,13 @@ func (p *Player) PlayNext(target string) error {
 
 		if err != nil {
 			p.log.Warn().Str("title", track.Title).Err(err).Msg("track_skipped_error")
+			p.mu.Lock()
+			qEmpty := len(p.queue) == 0
+			p.mu.Unlock()
+			if qEmpty {
+				p.emitStatus(StatusError)
+				return fmt.Errorf("%w: %v", ErrTrackStartFailed, err)
+			}
 			continue
 		}