Missing nindent in manager/deployment tolerations v2.20.0

[TBeijen]

Chart v2.20.0 introduces ability to specify nodeSelector and tolerations per component.

The if/else path used when using globally defined tolerations, misses an nindent causing invalid YAML to be rendered.

(Now one could work around this by specifying at the component level. But that's introducing more complexity in values to work around a bug. We are skipping this chart version and hoping for a quick patch release.)

See: v2.19.0...v2.20.0

Expected Behavior

Same values as used for v2.19.0 rendering same tolerations as v2.20.0 without error.

Actual Behavior

Error: YAML parse error on entertainment-keda/charts/keda/templates/manager/deployment.yaml: error converting YAML to JSON: yaml: line 133: mapping values are not allowed in this context

Use --debug flag to render out invalid YAML

Steps to Reproduce the Problem

Rendering chart with these values:

tolerations:
  - key: example
    effect: NoSchedule

Specifications

• Chart Version: v2.20.0

[TBeijen]

I'll create a PR

N/m, dupe of #866

Worth noting that copilot happily reviews it as passing, not mentioning the inconsistent use of if/else and with.

While at it anyway, PR with minor improvement and copilot review instructions: #869

      # with, elegant by only once requiring nindent
      {{- with .Values.operator.nodeSelector | default .Values.nodeSelector }}
        {{- toYaml . | nindent 8 }}
      {{- end }}

      # if/else, dupliacte toYaml
      {{- if .Values.operator.tolerations }}
      tolerations:
        {{- toYaml .Values.operator.tolerations | nindent 8 }}
      {{- else if .Values.tolerations }}
      tolerations:
        {{- toYaml .Values.tolerations | nindent 8 }}
      {{- end }}