Silenced GGCAT compilation warnings, added build_config to every

colorset builder

Author: Alessio-Campa

CMakeLists.txt

@@ -46,7 +46,7 @@ include_directories(external/sketch/include/blaze)
 
 add_custom_target(
   ggcat_cpp_api
-  COMMAND make
+  COMMAND ${CMAKE_COMMAND} -E env CARGO_ENCODED_RUSTFLAGS="-Awarnings" make
   WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/external/ggcat/crates/capi/ggcat-cpp-api
 )
 set(GGCAT_CPP_BINDINGS ${CMAKE_SOURCE_DIR}/external/ggcat/crates/capi/ggcat-cpp-api/lib/libggcat_cpp_bindings.a)

include/builders/builder.hpp

@@ -39,7 +39,7 @@ struct index<ColorSets>::builder {
             uint64_t num_unitigs = 0;
             uint64_t num_distinct_color_sets = 0;
 
-            typename ColorSets::builder builder(m_build_config.num_colors);
+            typename ColorSets::builder builder(m_build_config.num_colors, m_build_config);
 
             const uint64_t num_threads = m_build_config.num_threads;
             kmeans::thread_pool threads(num_threads);

include/builders/differential_builder.hpp

@@ -253,7 +253,7 @@ struct index<ColorSets>::differential_builder {
             thread_slices.push_back(s);
 
             std::vector<typename ColorSets::builder> thread_builders(thread_slices.size(),
-                                                                     num_colors);
+                                                                     typename ColorSets::builder(num_colors));
             std::vector<std::thread> threads(thread_slices.size());
 
             auto encode_color_sets = [&](uint64_t thread_id) {

include/builders/meta_differential_builder.hpp

@@ -81,7 +81,7 @@ struct index<ColorSets>::meta_differential_builder {
                 thread_slices.push_back(s);
 
                 std::vector<differential::builder> thread_builders(thread_slices.size(),
-                                                                   num_partition_colors);
+                                                                   differential::builder(num_partition_colors));
                 std::vector<std::thread> threads(thread_slices.size());
 
                 auto encode_color_sets = [&thread_builders, &thread_slices, &permutation,

include/color_sets/differential.hpp

@@ -6,9 +6,12 @@ struct differential {
     static const index_t type = index_t::DIFF;
 
     struct builder {
-        builder() : m_num_total_integers(0), m_num_sets(0) {}
-        builder(uint32_t num_colors)
-            : m_num_total_integers(0), m_num_sets(0), m_num_colors(num_colors) {}
+        explicit builder(const uint32_t num_colors = 0,
+                 build_configuration build_config = build_configuration())
+            : m_num_total_integers(0)
+            , m_num_sets(0)
+            , m_num_colors(num_colors)
+            , m_build_config(std::move(build_config)) {}
 
         void init_color_sets_builder(uint64_t num_colors) {
             m_num_colors = num_colors;
@@ -165,6 +168,8 @@ struct differential {
         std::vector<uint64_t> m_representative_offsets, m_color_set_offsets;
 
         std::vector<uint32_t> m_curr_representative;
+
+        build_configuration m_build_config;
     };
 
     struct forward_iterator {

include/color_sets/hybrid.hpp

@@ -18,20 +18,15 @@ struct hybrid {
     static const index_t type = index_t::HYBRID;
 
     struct builder {
-        builder() : m_num_color_sets(0) {}
-        builder(uint64_t num_colors) { init(num_colors); }
-
-        // builder(build_configuration& build_config)
-        //     : m_num_colors(0)
-        //     , m_sparse_set_threshold_size(0)
-        //     , m_very_dense_set_threshold_size(0)
-        //     , m_num_color_sets(0)
-        //     , m_num_total_integers(0)
-        //     , m_build_config(build_config) {}
-        // builder(build_configuration& build_config, const uint64_t num_colors)
-        //     : m_build_config(build_config) {
-        //     init(num_colors);
-        // }
+        // builder() : m_num_color_sets(0) { init(0); }
+        // builder(uint64_t num_colors) { init(num_colors); }
+
+        explicit builder(const uint32_t num_colors = 0,
+                 build_configuration build_config = build_configuration())
+            : m_build_config(std::move(build_config))
+        {
+            init(num_colors);
+        }
 
         void init(uint64_t num_colors) {
             m_num_colors = num_colors;

include/color_sets/meta.hpp

@@ -17,7 +17,12 @@ struct meta {
     };
 
     struct builder {
-        builder() : m_offset(0) { m_meta_color_sets_offsets.push_back(0); }
+        explicit builder(build_configuration build_config = build_configuration())
+            : m_offset(0)
+            , m_build_config(std::move(build_config))
+        {
+            m_meta_color_sets_offsets.push_back(0);
+        }
 
         void init_meta_color_sets_builder(
             uint64_t num_integers_in_metacolor_sets, uint64_t num_color_sets,
@@ -87,6 +92,8 @@ struct meta {
         std::vector<uint64_t> m_meta_color_sets_offsets;
 
         std::vector<partition_endpoint> m_partition_endpoints;
+
+        build_configuration m_build_config;
     };
 
     struct forward_iterator {

include/color_sets/meta_differential.hpp

@@ -16,7 +16,10 @@ struct meta_differential {
     };
 
     struct builder {
-        builder() : m_prev_docs(0) {
+        explicit builder(build_configuration build_config = build_configuration())
+            : m_prev_docs(0)
+            , m_build_config(std::move(build_config))
+        {
             m_partition_sets_offsets.push_back(0);
             m_relative_colors_offsets.push_back(0);
         }
@@ -107,6 +110,8 @@ struct meta_differential {
         uint64_t m_num_partition_sets;
 
         std::vector<partition_endpoint> m_partition_endpoints;
+
+        build_configuration m_build_config;
     };
 
     struct forward_iterator {