Fix Cuttlefish helper process leak on unresponsive ADB teardown#25
Open
9640-Akhil wants to merge 2 commits into
Open
Fix Cuttlefish helper process leak on unresponsive ADB teardown#259640-Akhil wants to merge 2 commits into
9640-Akhil wants to merge 2 commits into
Conversation
9640-Akhil
force-pushed
the
process_leak_fix_cuttlefish
branch
from
b6e3281 to
937ebe7
Compare
The teardown routine bypasses the graceful 'stop_cvd' command when Cuttlefish freezes, hangs, or when the ADB connection goes offline, proceeding to force-kill only 'crosvm' and 'run_cvd'. This leaks helper processes like 'tombstone_receiver' and 'socket_vsock_proxy', leaving TCP ports bound indefinitely and causing subsequent boot attempts to fail with 'Address already in use' errors. This change ensures 'stop_cvd' is always attempted gracefully and force-kills all remaining CVD helper processes in the fallback path to guarantee clean port release.
9640-Akhil
force-pushed
the
process_leak_fix_cuttlefish
branch
from
937ebe7 to
06e93ea
Compare
Use a single directory-targeted pkill command instead of maintaining a hardcoded list of individual helper processes and running multiple separate SSH commands.
9640-Akhil
force-pushed
the
process_leak_fix_cuttlefish
branch
from
59eec5e to
62d8bcf
Compare
AashutoshMurthy
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cuttlefish teardown routine bypasses the graceful
stop_cvdcommand when Cuttlefish freezes, hangs, or when theADBconnection goes offline, proceeding to force-kill onlycrosvmandrun_cvd. This leaks helper processes liketombstone_receiverandsocket_vsock_proxy, leaving TCP ports bound indefinitely and causing subsequent boot attempts to fail withAddress already in useerrors.This change ensures
stop_cvdis always attempted gracefully and force-kills remaining CVD helper processes in the fallback path to guarantee clean port release.