Add an owner of bios settings to a server

Author: SzymonSAP

internal/controller/biossettings_controller.go

@@ -195,6 +195,12 @@ func (r *BiosSettingsReconciler) reconcile(ctx context.Context, log logr.Logger,
 		log.V(1).Info("referred server object could not be fetched")
 		return ctrl.Result{}, err
 	}
+
+	if err := r.setOwnerToServer(ctx, biosSettings, server); err != nil {
+		log.V(1).Error(err, "failed to set bios settings owner reference to server", "biosSettings", biosSettings.Name, "server", server.Name)
+		return ctrl.Result{}, fmt.Errorf("failed to set owner reference to server: %w", err)
+	}
+
 	// patch server with biossettings reference
 	if server.Spec.BIOSSettingsRef == nil {
 		if err := r.patchBiosSettingsRefOnServer(ctx, log, server, &corev1.LocalObjectReference{Name: biosSettings.Name}); err != nil {
@@ -229,6 +235,21 @@ func (r *BiosSettingsReconciler) reconcile(ctx context.Context, log logr.Logger,
 	return r.ensureBIOSSettingsStateTransition(ctx, log, bmcClient, biosSettings, server)
 }
 
+func (r *BiosSettingsReconciler) setOwnerToServer(ctx context.Context, biosSettings *metalv1alpha1.BIOSSettings, server *metalv1alpha1.Server) error {
+	if controllerutil.HasControllerReference(biosSettings) {
+		return nil
+	}
+
+	biosSettingsBase := biosSettings.DeepCopy()
+	if err := controllerutil.SetControllerReference(server, biosSettings, r.Scheme); err != nil {
+		return fmt.Errorf("failed to set controller reference for biosSettings: %w", err)
+	}
+	if err := r.Patch(ctx, biosSettings, client.MergeFrom(biosSettingsBase)); err != nil {
+		return fmt.Errorf("failed to patch server with controller reference: %w", err)
+	}
+	return nil
+}
+
 func (r *BiosSettingsReconciler) ensureBIOSSettingsStateTransition(
 	ctx context.Context,
 	log logr.Logger,

internal/controller/biossettings_controller_test.go

@@ -13,6 +13,7 @@ import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	v1 "k8s.io/api/core/v1"
+	"k8s.io/utils/ptr"
 
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -105,7 +106,14 @@ var _ = Describe("BIOSSettings Controller", func() {
 		)
 
 		Eventually(Object(biosSettingsV1)).Should(
-			HaveField("Status.State", metalv1alpha1.BIOSSettingsStateApplied),
+			HaveField("OwnerReferences", ContainElement(metav1.OwnerReference{
+				APIVersion:         "metal.ironcore.dev/v1alpha1",
+				Kind:               "Server",
+				Name:               server.Name,
+				UID:                server.UID,
+				Controller:         ptr.To(true),
+				BlockOwnerDeletion: ptr.To(true),
+			})),
 		)
 
 		By("Creating a BIOSSetting V2")