fix analysis warnings: parameter assignment allowed for now

desmonddak · desmonddak · commit c0588fd2f1a5 · 2026-03-06T09:39:13.000-08:00
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -128,7 +128,7 @@ linter:
     - overridden_fields
     - package_names
     - package_prefixed_library_names
-    - parameter_assignments
+    # - parameter_assignments # common pattern in ROHD modules
     - prefer_adjacent_string_concatenation
     - prefer_asserts_in_initializer_lists
     - prefer_asserts_with_message
diff --git a/lib/src/summation/summation_base.dart b/lib/src/summation/summation_base.dart
@@ -137,7 +137,6 @@ abstract class SummationBase extends Module {
     } else {
       // if it's a LogicValue, then don't assume the width is necessary
       if (value is LogicValue) {
-        // ignore: parameter_assignments
         value = value.toBigInt();
       }
 
diff --git a/test/summation/summation_test_utils.dart b/test/summation/summation_test_utils.dart
@@ -51,7 +51,6 @@ int goldenSum(
 
   maxVal ??= (1 << width) - 1;
   if (maxVal > (1 << width) - 1) {
-    // ignore: parameter_assignments
     maxVal = (1 << width) - 1;
   }
   minVal ??= 0;

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,6 @@ abstract class SummationBase extends Module {`
`137`	`137`	`} else {`
`138`	`138`	`// if it's a LogicValue, then don't assume the width is necessary`
`139`	`139`	`if (value is LogicValue) {`
`140`		`- // ignore: parameter_assignments`
`141`	`140`	`value = value.toBigInt();`
`142`	`141`	`}`
`143`	`142`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ int goldenSum(`
`51`	`51`
`52`	`52`	`maxVal ??= (1 << width) - 1;`
`53`	`53`	`if (maxVal > (1 << width) - 1) {`
`54`		`- // ignore: parameter_assignments`
`55`	`54`	`maxVal = (1 << width) - 1;`
`56`	`55`	`}`
`57`	`56`	`minVal ??= 0;`