[MIG] account_reconcile_bg: Migration to 19.0

feg-adhoc · feg-adhoc · commit 166b6346ddec · 2026-05-29T17:19:05.000-03:00
diff --git a/account_reconcile_bg/__manifest__.py b/account_reconcile_bg/__manifest__.py
@@ -19,14 +19,14 @@
 ##############################################################################
 {
     "name": "Account Reconcile Background",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "category": "Accounting",
     "author": "ADHOC SA",
     "website": "https://www.adhoc.com.ar",
     "license": "AGPL-3",
     "summary": "Process bank reconciliation in background for large payment batches",
     "depends": [
-        "account_accountant",
+        "account_accountant_batch_payment",
         "base_bg",
     ],
     "data": [
diff --git a/account_reconcile_bg/data/ir_config_parameter_data.xml b/account_reconcile_bg/data/ir_config_parameter_data.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
 
-    <!-- Parámetro de configuración para el umbral de líneas -->
     <record id="config_lines_threshold" model="ir.config_parameter">
         <field name="key">account_reconcile_bg.lines_threshold</field>
         <field name="value">100</field>
diff --git a/account_reconcile_bg/models/__init__.py b/account_reconcile_bg/models/__init__.py
@@ -1,5 +1,4 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from . import bank_rec_widget
 from . import account_bank_statement_line
 from . import account_move_line
 from . import bg_job
diff --git a/account_reconcile_bg/models/account_bank_statement_line.py b/account_reconcile_bg/models/account_bank_statement_line.py
@@ -2,8 +2,6 @@
 # For copyright and license notices, see __manifest__.py file in module root
 # directory
 ##############################################################################
-import logging
-
 from markupsafe import Markup
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
@@ -14,42 +12,68 @@ class AccountBankStatementLine(models.Model):
 
     reconciliation_in_background = fields.Boolean(
         string="Reconciliation in Background",
-        default=False,
         readonly=True,
         help="Indicates that this line is being reconciled in background",
     )
 
-    def _bg_validate_reconciliation(self, selected_aml_ids=None):
-        """
-        Método ejecutado en background para validar la conciliación.
-        Se llama desde el job de base_bg.
-
-        :param selected_aml_ids: IDs de las líneas seleccionadas por el usuario
-        """
+    def set_batch_payment_bank_statement_line(self, batch_payment_id):
         self.ensure_one()
-        _logger = logging.getLogger(__name__)
 
-        # Preparar datos para mensaje
-        base_url = self.env["ir.config_parameter"].sudo().get_param("web.base.url")
-        st_line_url = f"{base_url}/odoo/account.bank.statement.line/{self.id}"
-        st_line_name = self.name or f"Line {self.id}"
+        if self.env.context.get("account_reconcile_bg_skip"):
+            return super().set_batch_payment_bank_statement_line(batch_payment_id)
 
-        try:
-            # Crear el widget de conciliación
-            wizard = self.env["bank.rec.widget"].with_context(default_st_line_id=self.id).new({})
+        if self.reconciliation_in_background:
+            raise UserError(
+                _("This reconciliation is already being processed in background. Please wait until it finishes.")
+            )
+
+        batch_payment = self.env["account.batch.payment"].browse(batch_payment_id)
+        threshold = int(
+            self.env["ir.config_parameter"].sudo().get_param("account_reconcile_bg.lines_threshold", "100")
+        )
+        if len(batch_payment.payment_ids) < threshold:
+            return super().set_batch_payment_bank_statement_line(batch_payment_id)
+
+        self._enqueue_batch_reconciliation(batch_payment_id)
+
+    def _enqueue_batch_reconciliation(self, batch_payment_id):
+        self.write({"reconciliation_in_background": True})
+        self.env.flush_all()
 
-            _logger.info(f"[BG] Wizard created for st_line {self.id}")
+        try:
+            self.env["base.bg"].bg_enqueue_records(
+                self,
+                "_bg_set_batch_payment_bank_statement_line",
+                threshold=1,
+                name=_("Bank Reconciliation: %s") % self.name,
+                priority=5,
+                batch_payment_id=batch_payment_id,
+            )
+        except Exception:
+            self.write({"reconciliation_in_background": False})
+            raise
 
-            # Agregar las líneas al widget correctamente usando el método interno
-            if selected_aml_ids:
-                amls = self.env["account.move.line"].browse(selected_aml_ids)
-                wizard._action_add_new_amls(amls, allow_partial=False)
+        self.env["bus.bus"]._sendone(
+            self.env.user.partner_id,
+            "simple_notification",
+            {
+                "type": "success",
+                "message": _(
+                    "This reconciliation is being processed in background. You will be notified when it's done."
+                ),
+            },
+        )
 
-            # Ejecutar la validación con el context manager
-            with wizard._action_validate_method():
-                wizard._action_validate()
+    def _bg_set_batch_payment_bank_statement_line(self, batch_payment_id=None):
+        self.ensure_one()
+        base_url = self.env["ir.config_parameter"].sudo().get_param("web.base.url")
+        st_line_url = f"{base_url}/odoo/account.bank.statement.line/{self.id}"
+        st_line_name = self.name or f"Line {self.id}"
 
-            # Retornar mensaje de éxito
+        try:
+            self.with_context(account_reconcile_bg_skip=True).set_batch_payment_bank_statement_line(
+                batch_payment_id
+            )
             return Markup(
                 _("Bank reconciliation completed successfully:<br><a href='%s' target='_blank'>%s</a>")
                 % (st_line_url, st_line_name)
@@ -62,13 +86,8 @@ def _bg_validate_reconciliation(self, selected_aml_ids=None):
         finally:
             self.write({"reconciliation_in_background": False})
 
-    @api.constrains(
-        "amount",
-        "amount_currency",
-        "currency_id",
-    )
+    @api.constrains("amount", "amount_currency", "currency_id")
     def _check_reconciliation_in_background(self):
-        """Valida que no se modifiquen líneas en proceso de conciliación background."""
         if self.env.context.get("bg_job"):
             return
         for line in self:
diff --git a/account_reconcile_bg/models/account_move_line.py b/account_reconcile_bg/models/account_move_line.py
@@ -10,7 +10,6 @@ class AccountMoveLine(models.Model):
 
     reconciliation_in_background = fields.Boolean(
         string="Reconciliation in Background",
-        default=False,
         readonly=True,
         help="Indicates that this line is being reconciled in background",
     )
diff --git a/account_reconcile_bg/models/bank_rec_widget.py b/account_reconcile_bg/models/bank_rec_widget.py
diff --git a/account_reconcile_bg/models/bg_job.py b/account_reconcile_bg/models/bg_job.py
@@ -9,34 +9,20 @@ class BgJob(models.Model):
     _inherit = "bg.job"
 
     def cancel(self, message: str | None = None):
-        """Override para limpiar el flag cuando se cancela el job."""
         res = super().cancel(message=message)
-        self.filtered(
-            lambda j: j.model == "account.bank.statement.line" and j.method == "_bg_validate_reconciliation"
-        )._clean_reconciliation_flag()
+        self._clear_reconciliation_bg_flag()
         return res
 
     def fail(self, error_message: str):
-        """Override para limpiar el flag cuando falla el job."""
         res = super().fail(error_message)
-        self.filtered(
-            lambda j: j.model == "account.bank.statement.line" and j.method == "_bg_validate_reconciliation"
-        )._clean_reconciliation_flag()
+        self._clear_reconciliation_bg_flag()
         return res
 
-    def _clean_reconciliation_flag(self):
-        """Limpia el flag reconciliation_in_background para jobs de conciliación."""
-        for job in self:
-            kwargs = job.kwargs_json or {}
-            # Limpiar flag de la línea de extracto
-            record_ids = kwargs.get("_record_ids", [])
-            if record_ids:
-                lines = self.env["account.bank.statement.line"].browse(record_ids).exists()
-                if lines:
-                    lines.write({"reconciliation_in_background": False})
-            # Limpiar flag de las líneas de pago (solo las que existen)
-            selected_aml_ids = kwargs.get("selected_aml_ids", [])
-            if selected_aml_ids:
-                amls = self.env["account.move.line"].browse(selected_aml_ids).exists()
-                if amls:
-                    amls.write({"reconciliation_in_background": False})
+    def _clear_reconciliation_bg_flag(self):
+        for job in self.filtered(
+            lambda j: j.model == "account.bank.statement.line"
+            and j.method == "_bg_set_batch_payment_bank_statement_line"
+        ):
+            self.env["account.bank.statement.line"].browse(
+                (job.kwargs_json or {}).get("_record_ids", [])
+            ).exists().write({"reconciliation_in_background": False})
diff --git a/account_reconcile_bg/tests/test_account_reconcile_bg.py b/account_reconcile_bg/tests/test_account_reconcile_bg.py

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ class AccountMoveLine(models.Model):`
`10`	`10`
`11`	`11`	`reconciliation_in_background = fields.Boolean(`
`12`	`12`	`string="Reconciliation in Background",`
`13`		`- default=False,`
`14`	`13`	`readonly=True,`
`15`	`14`	`help="Indicates that this line is being reconciled in background",`
`16`	`15`	`)`