Add files via upload

Author: immortalbob

CHANGELOG.md

@@ -4,6 +4,25 @@ All notable changes to Mnemolis are documented here, from v3.45.0 onward. For ev
 
 ---
 
+## [3.56.1]
+
+### Fixed — fusion no longer carries `history`'s honest abstentions as noise
+
+Found while CLI-verifying v3.56.0 for release: *"what are the latest AI trends"* and *"tell me about the history of ancient rome"* correctly avoided the keyword triggers (those regression pins held), but the **LLM fusion picker included the `history` source anyway** — its own NAME attracts it for those phrasings — and its plain-prose *"I couldn't identify which sensor or metric you mean…"* abstention was fused into otherwise-good answers as a trailing noise block.
+
+Fixed with the project's established two-part pattern (the discourse-framing precedent explicitly rejects description-nudging as the sole lever):
+
+- The source **description is corrected where it was genuinely inaccurate** — it now states it covers THIS house's own sensors and services only, NOT world history, general knowledge, news, or public/industry trends.
+- The **verifiable lever**: `history`'s five honest-abstention messages ("couldn't identify which sensor", "couldn't identify which kind of event", the ambiguity ask, "requires temporal pattern detection", "no recorded metrics yet") joined `_looks_empty()`'s canonical phrase list, so fusion drops them exactly as it drops any other member with nothing to contribute. The `**` structural guard means no real history answer (headers are always `**{name} — …**`) can ever match; the plain-prose event-count answers ("1 opening today, …") were verified to survive the new phrases, with pins.
+
+Field-verified before tagging: both genre queries re-run against a live deployment came back with no trailing `[HISTORY]` block, on both fresh phrasings and the original cached-then-expired ones.
+
+### Changed
+- **Dependency: `mcp[cli]` 1.27.2 → 1.28.1** (Dependabot). Full test suite — including the MCP transport tests — run against 1.28.1 before packaging, not just trusted from the PR.
+- Version bumped to 3.56.1. Test suite: **1697 passing** (3 new pins for the abstention/`_looks_empty` contract), ruff clean. One stale comment fixed (`cache_ttl_history_seconds` referenced the removed sampling-interval setting).
+
+---
+
 ## [3.56.0]
 
 ### Added — the `history` source: time-series memory for the house (opt-in, off by default)

app/main.py

@@ -388,7 +388,7 @@ async def lifespan(app: FastAPI):
 app = FastAPI(
     title="Mnemolis",
     description="Unified local knowledge search API with multi-source fusion. Routes queries to Kiwix, Open-Meteo, FreshRSS, SearXNG, Uptime Kuma, or multiple sources concurrently.",
-    version="3.56.0",
+    version="3.56.1",
     lifespan=lifespan,
 )
 

app/router.py

@@ -427,7 +427,7 @@ def _search_changes(query: str) -> str:
     "uptime": "Uptime Kuma monitor status. Use when asked about service status, what is down, or network health.",
     "ha": "Home Assistant entity states. Use for house status summaries, which lights are on, door and lock status, battery levels, indoor sensors, motion events, or power consumption.",
     "changes": "Snapshot diff engine. Use when asked what changed, any new outages, weather changes, or new news since a given time.",
-    "history": "Recorded history of the house's own sensors and services — temperature, CO2, humidity, power, service uptime, and door/motion events over time. Use for questions about past values, highs/lows, averages, counts, or trends.",
+    "history": "Recorded readings from THIS house's own sensors and services only — temperature, CO2, humidity, power, service uptime, and door/motion events over time. Use for questions about this home's past sensor values, highs/lows, averages, counts, or sensor trends. NOT for world history, general knowledge, news, or public/industry trends.",
     "fusion": "Multi-source fusion — queries multiple sources concurrently and merges results. Use for complex queries that benefit from combining offline knowledge, live web, and recent news.",
 }
 

app/sources/fusion.py

@@ -216,6 +216,19 @@ def _looks_empty(result: str) -> bool:
     "unable to retrieve", "no valid sources", "no results returned",
     "no entity states returned", "no matching entities found",
     "no significant changes",
+    # history's four honest-abstention messages (v3.56.0 field finding:
+    # LLM fusion routing includes `history` for phrasings like "latest AI
+    # trends" and "history of ancient rome" — the source's own name pulls
+    # it in — and its plain-prose "couldn't identify" abstention was fused
+    # into otherwise-good answers as a trailing noise block). All four are
+    # plain prose with no `**`, so the structural guard above keeps every
+    # real history answer — whose headers are always `**{name} — …**` —
+    # untouchable by this list. Same verified-against-the-actual-return-
+    # statements discipline as every phrase above.
+    "couldn't identify which sensor", "couldn't identify which kind of event",
+    "sensors match that — which did you mean",
+    "requires temporal pattern detection",
+    "no recorded metrics yet",
 )
 
 

tests/test_history_source.py

@@ -382,3 +382,51 @@ def test_outdoor_sensor_resolves_via_area_class(self, enabled, temp_history_db):
         with patch("app.sources.home_assistant._detect_area", return_value="outside"):
             out = HS.search("how cold did it get outside today")
         assert "99.9" in out and "which did you mean" not in out
+
+    def test_abstention_messages_are_looks_empty_for_fusion(self, enabled, temp_history_db):
+        # Field finding: LLM fusion routing pulled `history` in for
+        # "latest AI trends" / "history of ancient rome" (the source's
+        # own name attracts it) and fused the plain-prose abstention in
+        # as a trailing noise block. The canonical _looks_empty filter
+        # must recognize all five abstentions — and must NOT catch a
+        # real answer, whose header's `**` is the structural guard.
+        from app.sources.fusion import _looks_empty
+        # Empty catalog -> "No recorded metrics yet" abstention.
+        with patch("app.sources.home_assistant._detect_area", return_value=None):
+            assert _looks_empty(HS.search("what are the latest AI trends today")) is True
+
+        _seed(temp_history_db, [
+            ("sensor.lr", 74.0, "°F", "Living Room Temperature", "living_room", "temperature"),
+        ])
+        with patch("app.sources.home_assistant._detect_area", return_value=None):
+            # Populated catalog, unresolvable query -> "couldn't identify".
+            assert _looks_empty(HS.search("what are the latest AI trends today")) is True
+            # A real answer must survive.
+            assert _looks_empty(HS.search("living room temperature today")) is False
+
+    def test_ambiguity_ask_is_looks_empty_for_fusion(self, enabled, temp_history_db):
+        from app.sources.fusion import _looks_empty
+        _seed(temp_history_db, [
+            ("sensor.a", 74.0, "°F", "Living Room Temperature", "living_room", "temperature"),
+            ("sensor.b", 99.9, "°F", "Temperature", "outside", "temperature"),
+        ])
+        with patch("app.sources.home_assistant._detect_area", return_value=None):
+            ask = HS.search("average temperature today")
+        assert "which did you mean" in ask
+        assert _looks_empty(ask) is True
+
+    def test_event_count_answer_is_not_looks_empty(self, enabled, temp_temporal_db):
+        # "1 opening today, most recently …" is plain prose with no `**`;
+        # it must survive the new phrases. Same for the honest zero.
+        from app.sources.fusion import _looks_empty
+        now = datetime.now(timezone.utc)
+        con = sqlite3.connect(temp_temporal_db)
+        con.execute("INSERT INTO temporal_events (source, event_type, timestamp, raw_detail) "
+                    "VALUES (?,?,?,?)",
+                    ("ha", "binary_sensor.front_door:opened", _iso(now - timedelta(hours=1)), ""))
+        con.commit()
+        con.close()
+        with patch.object(settings, "temporal_pattern_detection_enabled", True):
+            out = HS.search("how many times did the front door open today")
+        assert out.startswith("1 opening")
+        assert _looks_empty(out) is False