Get rid of old modules once the notebooks and scripts are consolidated

[andreufont]

No need to keep old_ files, or the LikelihoodParameter class.

Let's wait a week or so to consolidate all the changes, before removing these.

[andreufont]

@marlena6 , I think we are ready for this. We could get rid of:

• lyaP3D.py
• forestflow_emu.py
• likelihood_parameter.py
• old_likelihood.py
• old_minimizer.py
• old_theory.py
• iminuit_minimizer.py
• old_fitter.py

This would break several notebooks that still used these, that's why I haven't removed them yet.

One option is to do first a separate cleanup task to remove old notebooks, then make sure the ones we want to keep don't use these old objects, then remove the old objects.

There is no rush, we can do this at another time, but since I saw you deleting old files I got inspired :-)

[marlena6]

I agree. For starters, I've made an 'obsolete' folder in my new branch (where I'm working on a bunch of the changes for the full pipeline run) and put them there, and I will do the same thing with the old notebooks. Just in case we find out there are some functions that didn't get ported over that we want to go back and easily check. Then I think once a full sampling run on a forecast with contaminants etc is working well, for IGM and Lya parameters, we can just delete them (they'll always be in the Github history anyway)