Fix mailto handling

Author: reithor

src/lib/Form/EventSubscriber/FixUrlProtocolListener.php

@@ -52,8 +52,15 @@ public function onSubmit(FormEvent $event): void
             return;
         }
 
-        $schemaSeparator = $this->hasAuthority($this->defaultProtocol) ? '://' : ':';
-        if (!preg_match('~^(?:[/.]|[\w+.-]+' . $schemaSeparator . '|[^:/?@#]++@)~', $dataLink)) {
+        if ($this->hasAuthority($this->defaultProtocol)) {
+            $schemaSeparator = '://';
+            $regExp = '~^(?:[/.]|[\w+.-]+//|[^:/?@#]++@)~';
+        } else {
+            $schemaSeparator = ':';
+            $regExp = '~^[\w+.-]+:~'; // allowing emails for non-http/https/file
+        }
+
+        if (!preg_match($regExp, $dataLink)) {
             $data['link'] = $this->defaultProtocol . $schemaSeparator . $dataLink;
             $event->setData($data);
         }

tests/lib/Form/EventSubscriber/FixUrlProtocolListenerTest.php

@@ -57,6 +57,11 @@ public static function provideUrlCases(): iterable
             ['link' => 'http://example.com'],
         ];
 
+        yield 'keep relative url with leading / intact' => [
+            ['link' => '/foo/bar'],
+            ['link' => '/foo/bar'],
+        ];
+
         yield 'keeps ftp intact' => [
             ['link' => 'ftp://example.com'],
             ['link' => 'ftp://example.com'],
@@ -73,9 +78,14 @@ public static function provideUrlCases(): iterable
             'tel',
         ];
 
+        yield 'keeps mailto intact' => [
+            ['link' => 'mailto:me@home.com'],
+            ['link' => 'mailto:me@home.com'],
+        ];
+
         yield 'adds default mailto' => [
-            ['link' => 'me@home.de'],
-            ['link' => 'mailto:me@home.de'],
+            ['link' => 'me@home'],
+            ['link' => 'mailto:me@home'],
             'mailto',
         ];