Changes from code review

reithor · reithor · commit 1080bbe68113 · 2026-01-29T16:58:56.000+01:00
diff --git a/src/lib/Form/EventSubscriber/FixUrlProtocolListener.php b/src/lib/Form/EventSubscriber/FixUrlProtocolListener.php
@@ -13,7 +13,10 @@
 use Symfony\Component\Form\FormEvent;
 use Symfony\Component\Form\FormEvents;
 
-class FixUrlProtocolListener implements EventSubscriberInterface
+/**
+ * @internal
+ */
+final class FixUrlProtocolListener implements EventSubscriberInterface
 {
     /** @var string|null */
     private $defaultProtocol;
@@ -68,7 +71,7 @@ public function onSubmit(FormEvent $event): void
 
     private function hasAuthority(string $protocol): bool
     {
-        return !in_array($protocol, ['mailto', 'tel']);
+        return !in_array($protocol, ['mailto', 'tel'], true);
     }
 
     public static function getSubscribedEvents(): array

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,10 @@`
`13`	`13`	`use Symfony\Component\Form\FormEvent;`
`14`	`14`	`use Symfony\Component\Form\FormEvents;`
`15`	`15`
`16`		`-class FixUrlProtocolListener implements EventSubscriberInterface`
	`16`	`+/**`
	`17`	`+ * @internal`
	`18`	`+ */`
	`19`	`+final class FixUrlProtocolListener implements EventSubscriberInterface`
`17`	`20`	`{`
`18`	`21`	`/** @var string\|null */`
`19`	`22`	`private $defaultProtocol;`
`@@ -68,7 +71,7 @@ public function onSubmit(FormEvent $event): void`
`68`	`71`
`69`	`72`	`private function hasAuthority(string $protocol): bool`
`70`	`73`	`{`
`71`		`- return !in_array($protocol, ['mailto', 'tel']);`
	`74`	`+ return !in_array($protocol, ['mailto', 'tel'], true);`
`72`	`75`	`}`
`73`	`76`
`74`	`77`	`public static function getSubscribedEvents(): array`