Skip to content

Commit d29710c

Browse files
authored
chore(runtime): bump managed ACP package versions (#488)
## Summary - Bump the managed Codex ACP package pin to 0.16.0. - Bump the managed Claude Agent ACP package pin to 0.47.0. - Keep ACP tool version assertions centralized while deriving test fixtures from the managed tool definitions. ## Test Plan - [x] cargo fmt --all -- --check - [x] cargo test -p aionui-runtime - [x] cargo clippy -p aionui-runtime -- -D warnings - [x] just push -u origin feat/acp-managed-tool-versions Co-authored-by: zynx <>
1 parent e03b030 commit d29710c

2 files changed

Lines changed: 24 additions & 9 deletions

File tree

crates/aionui-runtime/src/acp_tool_runtime/mod.rs

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,7 @@ mod tests {
997997
};
998998
let tool = ResolvedManagedAcpTool {
999999
id: ManagedAcpToolId::CodexAcp,
1000-
version: "0.14.0".into(),
1000+
version: ManagedAcpToolId::CodexAcp.version().into(),
10011001
root: PathBuf::from("/tmp/tool"),
10021002
entrypoint: PathBuf::from("/tmp/tool/dist/index.js"),
10031003
env_path_entries: vec![PathBuf::from("/tmp/tool/bin")],
@@ -1027,9 +1027,10 @@ mod tests {
10271027

10281028
#[test]
10291029
fn classify_error_detects_bundled_acp_validation_failure() {
1030-
let error = ManagedAcpToolError::invalid(
1031-
"bundled managed Codex ACP artifact failed validation under /app/resources/managed-resources/acp/codex-acp/0.14.0/linux-x64: managed ACP entrypoint missing",
1032-
);
1030+
let error = ManagedAcpToolError::invalid(format!(
1031+
"bundled managed Codex ACP artifact failed validation under /app/resources/managed-resources/acp/codex-acp/{}/linux-x64: managed ACP entrypoint missing",
1032+
ManagedAcpToolId::CodexAcp.version(),
1033+
));
10331034
let (kind, status_code) = classify_error(&error);
10341035

10351036
assert_eq!(kind, ManagedAcpToolFailureKind::BundledResourceInvalid);
@@ -1271,7 +1272,7 @@ mod tests {
12711272
let source_root = bundled_root
12721273
.join("acp")
12731274
.join("codex-acp")
1274-
.join("0.14.0")
1275+
.join(ManagedAcpToolId::CodexAcp.version())
12751276
.join(spec.manifest_key);
12761277
std::fs::create_dir_all(&source_root).unwrap();
12771278
std::fs::write(
@@ -1281,7 +1282,10 @@ mod tests {
12811282
.unwrap();
12821283

12831284
let runtime_root = tmp.path().join("runtime");
1284-
let tool_root = runtime_root.join("codex-acp").join("0.14.0").join(spec.manifest_key);
1285+
let tool_root = runtime_root
1286+
.join("codex-acp")
1287+
.join(ManagedAcpToolId::CodexAcp.version())
1288+
.join(spec.manifest_key);
12851289

12861290
managed_resources::set_managed_resources_mode(managed_resources::ManagedResourcesMode::Bundled);
12871291
let result = activate_local_tool_source(ManagedAcpToolId::CodexAcp, spec, &tool_root, None);
@@ -1311,7 +1315,7 @@ mod tests {
13111315
bundle_root
13121316
.join("acp")
13131317
.join("codex-acp")
1314-
.join("0.14.0")
1318+
.join(ManagedAcpToolId::CodexAcp.version())
13151319
.join("win32-x64")
13161320
);
13171321
}

crates/aionui-runtime/src/acp_tool_runtime/types.rs

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ impl ManagedAcpToolId {
2020

2121
pub fn version(self) -> &'static str {
2222
match self {
23-
Self::CodexAcp => "0.14.0",
24-
Self::ClaudeAgentAcp => "0.39.0",
23+
Self::CodexAcp => "0.16.0",
24+
Self::ClaudeAgentAcp => "0.47.0",
2525
}
2626
}
2727

@@ -218,6 +218,17 @@ impl ManagedAcpToolSupport {
218218
}
219219
}
220220

221+
#[cfg(test)]
222+
mod tests {
223+
use super::ManagedAcpToolId;
224+
225+
#[test]
226+
fn managed_acp_tool_versions_match_current_pins() {
227+
assert_eq!(ManagedAcpToolId::CodexAcp.version(), "0.16.0");
228+
assert_eq!(ManagedAcpToolId::ClaudeAgentAcp.version(), "0.47.0");
229+
}
230+
}
231+
221232
#[derive(Debug, Clone, thiserror::Error)]
222233
#[error("{message}")]
223234
pub struct ManagedAcpToolError {

0 commit comments

Comments
 (0)