Skip to content

Commit 7bd1b10

Browse files
authored
chore(skills): remove builtin aionui skills (#513)
## Summary - Remove the auto-injected builtin `aionui-skills` marketplace skill from the embedded builtin skill corpus. - Assert `/api/skills/builtin-auto` no longer returns `aionui-skills`. - Lower embedded auto-inject count expectations from 4 to 3 while leaving AionUi Butler skills unchanged. ## Test Plan - `cargo fmt --all -- --check` - `cargo test -p aionui-app --test skills_builtin_e2e` - `cargo test -p aionui-extension skill_service::tests::embedded_lists_auto_inject_from_corpus -- --exact` - `cargo clippy -p aionui-app -p aionui-extension -- -D warnings` - `cargo test --workspace` Note: `just push` was started after the commit, but was interrupted at user request because the full workspace test had already completed successfully. Co-authored-by: zk <>
1 parent 464f453 commit 7bd1b10

3 files changed

Lines changed: 7 additions & 55 deletions

File tree

crates/aionui-app/assets/builtin-skills/auto-inject/aionui-skills/SKILL.md

Lines changed: 0 additions & 53 deletions
This file was deleted.

crates/aionui-app/tests/skills_builtin_e2e.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,12 @@ async fn builtin_auto_lists_entries_from_embedded_corpus() {
120120
let json = body_json(resp).await;
121121
assert_eq!(json["success"], true);
122122
let arr = json["data"].as_array().unwrap();
123-
assert!(arr.len() >= 4, "expected ≥4 auto-inject entries, got {}", arr.len());
123+
assert!(arr.len() >= 3, "expected ≥3 auto-inject entries, got {}", arr.len());
124+
let names: Vec<&str> = arr.iter().filter_map(|item| item["name"].as_str()).collect();
125+
assert!(
126+
!names.contains(&"aionui-skills"),
127+
"aionui-skills should not be shipped as an auto-inject builtin skill: {names:?}",
128+
);
124129
for item in arr {
125130
assert!(item["name"].is_string());
126131
assert!(item["description"].is_string());

crates/aionui-extension/src/skill_service.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2154,7 +2154,7 @@ mod tests {
21542154
let paths = make_embedded_paths(tmp.path()).await;
21552155

21562156
let autos = list_builtin_auto_skills(&paths).await.unwrap();
2157-
assert!(autos.len() >= 4, "expected ≥4 auto-inject entries, got {}", autos.len());
2157+
assert!(autos.len() >= 3, "expected ≥3 auto-inject entries, got {}", autos.len());
21582158
for item in &autos {
21592159
assert!(
21602160
item.location.starts_with("auto-inject/"),

0 commit comments

Comments
 (0)