Skip to content

Commit 316d2c1

Browse files
committed
fix options
1 parent 2e43a3e commit 316d2c1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

kafka-streams-framework/src/main/java/org/hypertrace/core/kafkastreams/framework/rocksdb/BoundedMemoryConfigSetter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import org.rocksdb.CompressionType;
1919
import org.rocksdb.InfoLogLevel;
2020
import org.rocksdb.Options;
21-
import org.rocksdb.WriteOptions;
2221

2322
public class BoundedMemoryConfigSetter implements RocksDBConfigSetter {
2423

@@ -55,9 +54,10 @@ public void setConfig(String storeName, Options options, Map<String, Object> con
5554
}
5655

5756
if (configs.containsKey(WAL_DISABLED)) {
58-
options.setWalDir("");
59-
WriteOptions writeOptions = new WriteOptions();
60-
writeOptions.setDisableWAL(true);
57+
boolean disableWAL = Boolean.parseBoolean(String.valueOf(configs.get(WAL_DISABLED)));
58+
// WriteOptions.setDisableWAL() is per-write and cannot be applied through RocksDBConfigSetter.
59+
// setManualWalFlush suppresses implicit WAL flushes after each write; closest option-level equivalent.
60+
options.setManualWalFlush(disableWAL);
6161
}
6262

6363
if (configs.containsKey(OPTIMIZE_FOR_POINT_LOOKUPS)) {

0 commit comments

Comments
 (0)