Skip to content

Commit 4fba358

Browse files
emit metrics for dropped spans at tenant level (#239)
* increment metrics for dropped spans at tenant level * add missing return statement
1 parent c8f0d31 commit 4fba358

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

span-normalizer/span-normalizer/src/main/java/org/hypertrace/core/spannormalizer/jaeger/JaegerSpanPreProcessor.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,12 @@ public class JaegerSpanPreProcessor
2323
implements Transformer<byte[], Span, KeyValue<byte[], PreProcessedSpan>> {
2424

2525
static final String SPANS_COUNTER = "hypertrace.reported.spans";
26+
private static final String DROPPED_SPANS_COUNTER = "hypertrace.reported.spans.dropped";
2627
private static final Logger LOG = LoggerFactory.getLogger(JaegerSpanPreProcessor.class);
2728
private static final ConcurrentMap<String, Counter> statusToSpansCounter =
2829
new ConcurrentHashMap<>();
30+
private static final ConcurrentMap<String, Counter> tenantToSpansDroppedCount =
31+
new ConcurrentHashMap<>();
2932
private TenantIdHandler tenantIdHandler;
3033
private SpanFilter spanFilter;
3134

@@ -94,6 +97,14 @@ PreProcessedSpan preProcessSpan(Span span) {
9497
String tenantId = maybeTenantId.get();
9598

9699
if (spanFilter.shouldDropSpan(span, tags)) {
100+
// increment dropped counter at tenant level
101+
tenantToSpansDroppedCount
102+
.computeIfAbsent(
103+
tenantId,
104+
tenant ->
105+
PlatformMetricsRegistry.registerCounter(
106+
DROPPED_SPANS_COUNTER, Map.of("tenantId", tenantId)))
107+
.increment();
97108
return null;
98109
}
99110

0 commit comments

Comments
 (0)