Skip to content

Commit 4470461

Browse files
authored
chore(client-registry): entity data caching client (#259)
1 parent 4300b90 commit 4470461

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

hypertrace-trace-enricher/hypertrace-trace-enricher-impl/src/main/java/org/hypertrace/traceenricher/enrichment/clients/ClientRegistry.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.hypertrace.core.datamodel.Event;
66
import org.hypertrace.core.datamodel.StructuredTrace;
77
import org.hypertrace.entity.data.service.client.EdsCacheClient;
8+
import org.hypertrace.entity.data.service.rxclient.EntityDataClient;
89
import org.hypertrace.trace.accessor.entities.TraceEntityAccessor;
910
import org.hypertrace.trace.reader.attributes.TraceAttributeReader;
1011
import org.hypertrace.traceenricher.enrichment.enrichers.cache.EntityCache;
@@ -23,6 +24,8 @@ public interface ClientRegistry {
2324

2425
EdsCacheClient getEdsCacheClient();
2526

27+
EntityDataClient getEntityDataClient();
28+
2629
EntityCache getEntityCache();
2730

2831
CachingAttributeClient getCachingAttributeClient();

hypertrace-trace-enricher/hypertrace-trace-enricher-impl/src/main/java/org/hypertrace/traceenricher/enrichment/clients/DefaultClientRegistry.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public class DefaultClientRegistry implements ClientRegistry {
3434
private final ManagedChannel configServiceChannel;
3535
private final ManagedChannel entityServiceChannel;
3636
private final EdsCacheClient edsCacheClient;
37+
private final EntityDataClient entityDataClient;
3738
private final CachingAttributeClient cachingAttributeClient;
3839
private final EntityCache entityCache;
3940
private final TraceEntityAccessor entityAccessor;
@@ -63,11 +64,12 @@ public DefaultClientRegistry(Config config) {
6364
new EdsCacheClient(
6465
new EntityDataServiceClient(this.entityServiceChannel),
6566
EntityServiceClientConfig.from(config).getCacheConfig());
67+
this.entityDataClient = EntityDataClient.builder(this.entityServiceChannel).build();
6668
this.entityCache = new EntityCache(this.edsCacheClient);
6769
this.entityAccessor =
6870
new TraceEntityAccessorBuilder(
6971
EntityTypeClient.builder(this.entityServiceChannel).build(),
70-
EntityDataClient.builder(this.entityServiceChannel).build(),
72+
this.entityDataClient,
7173
this.cachingAttributeClient)
7274
.withEntityWriteThrottleDuration(
7375
config.hasPath(TRACE_ENTITY_WRITE_THROTTLE_DURATION)
@@ -106,6 +108,11 @@ public EdsCacheClient getEdsCacheClient() {
106108
return this.edsCacheClient;
107109
}
108110

111+
@Override
112+
public EntityDataClient getEntityDataClient() {
113+
return this.entityDataClient;
114+
}
115+
109116
@Override
110117
public EntityCache getEntityCache() {
111118
return this.entityCache;

0 commit comments

Comments
 (0)